GNU bug report logs - #45607
27.1; compiled replace-string breaks repeat-complex-command

Previous Next

Full log

Message #81 received at 45607 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: michael_heerdegen <at> web.de, darkfeline <at> felesatra.moe, 45607 <at> debbugs.gnu.org,
 juri <at> linkov.net
Subject: Re: bug#45607: 27.1; compiled replace-string breaks
 repeat-complex-command
Date: Tue, 09 Aug 2022 22:25:44 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Juri Linkov <juri <at> linkov.net>,  michael_heerdegen <at> web.de,
>   45607 <at> debbugs.gnu.org,  darkfeline <at> felesatra.moe
> Date: Tue, 09 Aug 2022 21:15:51 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Bonus points for calling use-region-p just once, not twice.
> 
> I don't really see a convenient way to do that in these cases -- the
> only ones I could think of (adding a new function to return both
> start/end, and then splice the results in into the `interactive' specs
> etc) would lead to obfuscated code.

What about cl-destructuring-bind and its ilk?

> (And it's not like this is performance critical anyway.)

It's IMO inelegant to make the same test twice in a row.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.