GNU bug report logs - #45604
[PATCH 0/1] Add magic-enum package

Previous Next

Full log

Message #11 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Anadon <joshua.r.marshall.1991 <at> gmail.com>
Cc: 45604 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] Added magic-enum header-only library as a package.
Date: Mon, 04 Jan 2021 14:06:14 +0100

Hello Anadon,

I have not yet built your package (because I'm currently also handling
another patch), but since you've requested review over at guix-devel,
I'll have a go at it.
For the future please note, that a delay of 2 days does not mean we
haven't noticed you at all.  The manual has the following to say for
committers:
> For anything else, please post to <guix-patches <at> gnu.org> and leave
> time for a review, without committing anything (*note Submitting
> Patches::).  If you didn’t receive any reply after two weeks, and if
> you’re confident, it’s OK to commit.

Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Ehh, somehow the commit message and everything is missing here.  Is
that intended or just misconfigured?

> ---
>  gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..ff10a4247b 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic.  This implementation
>  provides a number of utilities to make coding with expected
> cleaner.")
>      (home-page "https://tl.tartanllama.xyz/")
>      (license license:cc0)))
> +
> +(define-public magic-enum
> +    (package
> +      (name "magic-enum")
> +      (version "0.7.2")
> +      (home-page "https://github.com/Neargye/magic_enum")
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url home-page)
> +                      (commit (string-append "v" version))))
> +                (sha256
> +                 (base32
> +                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
> +                (modules '((guix build utils)))))
> +      (build-system cmake-build-system)
> +
> +      (inputs
> +       `(("gcc" ,gcc-10)))
The home-page claims, that it works with GCC>=9.  Have you encountered
any issues with gcc-9 instead?
> +      (synopsis "Header-only C++17 library for reflection for
> enums")
I feel as though that could be worded better.
> +      (description "Static reflection for enums (to string, from
> string,
> +iteration) for modern C++, work with any enum type without any macro
> or
> +boilerplate code")
Descriptions should be complete sentences and end with a period.
> +      (license license:expat)))

Regards,
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.