GNU bug report logs - #4548
23.1.50; hideshow.el - hs-show-block does not run hs-show-hook

Previous Next

Full log

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook
Date: Thu, 24 Sep 2009 15:35:14 +0200

[Message part 1 (text/plain, inline)]

In hideshow.el, there is a hook 'hs-show-hook' which should be run
whenever some text is shown again (i.e., unfolded).

However, the command hs-show-block does not run this hook; a (trivial)
patch which will fix this is attached.

Regards,
David

[hideshow-patch.diff (text/x-diff, inline)]

Index: hideshow.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v
retrieving revision 1.80
diff -u -r1.80 hideshow.el
--- hideshow.el	14 Aug 2009 23:02:41 -0000	1.80
+++ hideshow.el	24 Sep 2009 13:28:55 -0000
@@ -869,8 +869,8 @@
                    q (progn (hs-forward-sexp (match-data t) 1) (point)))))
       (when (and p q)
         (hs-discard-overlays p q)
-        (goto-char (if end q (1+ p)))))
-    (run-hooks 'hs-show-hook))))
+        (goto-char (if end q (1+ p))))))
+   (run-hooks 'hs-show-hook)))
 
 (defun hs-hide-level (arg)
   "Hide all blocks ARG levels below this block.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.