GNU bug report logs - #4548
23.1.50; hideshow.el - hs-show-block does not run hs-show-hook

Previous Next

Package: emacs;

Reported by: David Engster <deng <at> randomsample.de>

Date: Thu, 24 Sep 2009 13:40:04 UTC

Severity: normal

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4548 in the body.
You can then email your comments to 4548 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4548; Package emacs. (Thu, 24 Sep 2009 13:40:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to David Engster <deng <at> randomsample.de>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Thu, 24 Sep 2009 13:40:05 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook
Date: Thu, 24 Sep 2009 15:35:14 +0200

[Message part 1 (text/plain, inline)]
In hideshow.el, there is a hook 'hs-show-hook' which should be run
whenever some text is shown again (i.e., unfolded).

However, the command hs-show-block does not run this hook; a (trivial)
patch which will fix this is attached.

Regards,
David


[hideshow-patch.diff (text/x-diff, inline)]
Index: hideshow.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v
retrieving revision 1.80
diff -u -r1.80 hideshow.el
--- hideshow.el	14 Aug 2009 23:02:41 -0000	1.80
+++ hideshow.el	24 Sep 2009 13:28:55 -0000
@@ -869,8 +869,8 @@
                    q (progn (hs-forward-sexp (match-data t) 1) (point)))))
       (when (and p q)
         (hs-discard-overlays p q)
-        (goto-char (if end q (1+ p)))))
-    (run-hooks 'hs-show-hook))))
+        (goto-char (if end q (1+ p))))))
+   (run-hooks 'hs-show-hook)))
 
 (defun hs-hide-level (arg)
   "Hide all blocks ARG levels below this block.
Reply sent to Juanma Barranquero <lekktu <at> gmail.com>:
You have taken responsibility. (Fri, 25 Sep 2009 00:40:05 GMT) Full text and rfc822 format available.
Notification sent to David Engster <deng <at> randomsample.de>:
bug acknowledged by developer. (Fri, 25 Sep 2009 00:40:06 GMT) Full text and rfc822 format available.

Message #10 received at 4548-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: David Engster <deng <at> randomsample.de>
Cc: 4548-done <at> debbugs.gnu.org
Subject: Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run 
	hs-show-hook
Date: Fri, 25 Sep 2009 02:33:10 +0200

On Thu, Sep 24, 2009 at 15:35, David Engster <deng <at> randomsample.de> wrote:

> However, the command hs-show-block does not run this hook; a (trivial)
> patch which will fix this is attached.

Committed, thanks.

    Juanma
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Fri, 23 Oct 2009 14:24:13 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 300 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.