GNU bug report logs - #45050
[PATCH] gnu: Update emacs-guix to temporary repository.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45050 in the body.
You can then email your comments to 45050 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Update emacs-guix to temporary repository.
Date: Fri, 04 Dec 2020 21:21:52 -0800

[Message part 1 (text/plain, inline)]

Hello Guix,

Since 1.2 was released, I can update emacs-guix to use my repository
with patches to make it work again. It should be updated again when
guix.el has a new home.

Kindly,

John

[0001-gnu-Update-emacs-guix.patch (text/x-patch, attachment)]

[0001-gnu-Update-emacs-guix.patch (text/x-patch, attachment)]

Message #8 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 45050 <45050 <at> debbugs.gnu.org>
Subject: Oops!
Date: Fri, 4 Dec 2020 21:24:48 -0800

[Message part 1 (text/plain, inline)]

     
 

 
 
 
 Just one of those patches is required, sorry!
 
 
 

 
       

[Message part 2 (text/html, inline)]

Message #11 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: John Soo <jsoo1 <at> asu.edu>, 45050 <at> debbugs.gnu.org
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Mon, 07 Dec 2020 17:01:29 +0100

Hi John,

On Fri, 04 Dec 2020 at 21:21, John Soo <jsoo1 <at> asu.edu> wrote:
> Hello Guix,
>
> Since 1.2 was released, I can update emacs-guix to use my repository
> with patches to make it work again. It should be updated again when
> guix.el has a new home.

News about the new home?

> +              (uri (git-reference
> +                    ;; TODO: Use the official version when it has a new home
> +                    (url "https://github.com/jsoo1/guix.el")

Is it the most recent version where patches are applied?


Cheers,
simon

Message #14 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 45050 <45050 <at> debbugs.gnu.org>
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Mon, 7 Dec 2020 08:15:32 -0800

[Message part 1 (text/plain, inline)]

      
  

 Hi zimoun,
  

  
I still haven’t heard from the original maintainer about moving the sources to savannah. I sent an email maybe a week or two ago.   
  

  
The source I added here does have patches applied to make it work. My goal is to switch the source again when it ends up wherever it finally finds a new official location.   
  

  
What do you think?
  

  
- John
     

[Message part 2 (text/html, inline)]

Message #17 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45050 <45050 <at> debbugs.gnu.org>
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Mon, 07 Dec 2020 17:55:58 +0100

Hi,

On Mon, 07 Dec 2020 at 08:15, John Soo <jsoo1 <at> asu.edu> wrote:

> The source I added here does have patches applied to make it work. My
> goal is to switch the source again when it ends up wherever it finally
> finds a new official location.

Sounds good!

Cheers,
simon

Message #20 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45050 <at> debbugs.gnu.org
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Fri, 11 Dec 2020 18:47:49 +0100

Hi!

John Soo <jsoo1 <at> asu.edu> skribis:

>>From 28abdd7140c31425f6add54470ad683bc46e8de7 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Thu, 12 Nov 2020 23:04:27 -0800
> Subject: [PATCH] gnu: Update emacs-guix.
>
> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
> guix.

If it fixes one of the bugs in the tracker, we can mention it in the
commit log with “Fixes <https://bugs.gnu.org/XYZ>.”

>  (define-public emacs-guix
> -  (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
> -        (revision "2"))
> +  (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
> +         (revision "1"))

Please increment the revision number rather than decrement it.

>      (package
> -      (name "emacs-guix")
> -      (version (git-version "0.5.2" revision commit))

Please don’t reindent, the original formatting was fine.  :-)

Could you send an updated patch?

I guess it’s fine to use your repo until we hear from Alex Kost.

Thanks for taking care of this!

Ludo’.

Message #23 received at 45050 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45050 <at> debbugs.gnu.org
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Fri, 11 Dec 2020 12:27:51 -0800

[Message part 1 (text/plain, inline)]

Hello!

Ludovic Courtès <ludo <at> gnu.org> writes:

>> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
>> guix.
>
> If it fixes one of the bugs in the tracker, we can mention it in the
> commit log with “Fixes <https://bugs.gnu.org/XYZ>.”

Alright, done.

>>  (define-public emacs-guix
>> -  (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
>> -        (revision "2"))
>> +  (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
>> +         (revision "1"))
>
> Please increment the revision number rather than decrement it.

Ah yes, sorry I thought it would be the "revision at commit". I bumped
it to rev 3.

>>      (package
>> -      (name "emacs-guix")
>> -      (version (git-version "0.5.2" revision commit))
>
> Please don’t reindent, the original formatting was fine.  :-)

Oh oops, sorry. I think I forgot to reindent after a previous revision.

> I guess it’s fine to use your repo until we hear from Alex Kost.

Hopefully soon :)

Thanks for your review,

John

[0001-gnu-Update-emacs-guix.patch (text/x-patch, attachment)]

Message #28 received at 45050-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45050-done <at> debbugs.gnu.org
Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary
 repository.
Date: Sat, 12 Dec 2020 18:40:34 +0100

Hi John,

John Soo <jsoo1 <at> asu.edu> skribis:

> From 4fd99ba6fa6ef61e1077f1fcad6b5d56bbbbf69a Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Thu, 12 Nov 2020 23:04:27 -0800
> Subject: [PATCH] gnu: Update emacs-guix.
>
> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
> guix.
> * Fixes https://bugs.gnu.org/44062

I tweaked the commit log according to our conventions and applied it.
Great to see these fixes land, thanks!

BTW, I think it would be nice to preserve ChangeLog-style commit logs in
Emacs-Guix too, as has been done until now.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.