GNU bug report logs - #4485
23.1; bookmark-save performances

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Sat, 19 Sep 2009 08:40:06 UTC

Severity: normal

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 4485-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#4485: 23.1; bookmark-save performances
Date: Sun, 20 Sep 2009 10:55:43 -0400

> Hi, with current version of `bookmark-write-file' saving a big list of
> bookmarks is very long:

> More than 50s for 195 bookmarks.

> That's because entire `bookmark-alist' is given to pp:

> ,----[ bookmark.el:bookmark-write-file ]
> | (pp bookmark-alist (current-buffer))
> `----

> With this modification i made in bookmark+.el, for same 195 bookmarks,
> it take only 1.24s:

> ,----[ bookmark+.el:bookmark-write-file ]
> | (progn (insert "(")
> |        (dolist (i  bookmark-alist) (pp i (current-buffer)))
> |        (insert ")"))
> `----

> Little chunks of `bookmark-alist' are given one by one to pp and that is
> faster.
 
Thank you very much.  I've installed your patch,


        Stefan
This bug report was last modified 15 years and 332 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.