GNU bug report logs - #44771
[PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH

Previous Next

Package: guix-patches;

Reported by: Sergey Trofimov <sarg <at> sarg.org.ru>

Date: Fri, 20 Nov 2020 21:20:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44771: closed ([PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH)
Date: Sat, 28 Nov 2020 16:36:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 28 Nov 2020 16:34:58 +0000
with message-id <87360ttp71.fsf <at> cbaines.net>
and subject line Re: [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
has caused the debbugs.gnu.org bug report #44771,
regarding [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44771: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44771
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
Date: Fri, 20 Nov 2020 22:19:06 +0100
I've noticed that installing supercollider breaks qutebrowser. It happens
because QTWEBENGINEPROCESS_PATH is not a search path, but rather a full path
to a file.  So supercollider puts this var into the user profile and then
qutebrowser's wrapper incorrectly concatenates it with the path coming from
the qtwebengine dependency. Calibre package has the same defect.



[Message part 3 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 44771-done <at> debbugs.gnu.org
Subject: Re: [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
Date: Sat, 28 Nov 2020 16:34:58 +0000
[Message part 4 (text/plain, inline)]
Sergey Trofimov <sarg <at> sarg.org.ru> writes:

> ---
>  gnu/packages/ebook.scm        | 2 +-
>  gnu/packages/web-browsers.scm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 1609a631b7..e80ad45383 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -281,7 +281,7 @@
>                    (lambda (binary)
>                      (wrap-program binary
>                        ;; Make QtWebEngineProcess available.
> -                      `("QTWEBENGINEPROCESS_PATH" ":" =
> +                      `("QTWEBENGINEPROCESS_PATH" =
>                          ,(list (string-append
>                                  qtwebengine
>                                  "/lib/qt5/libexec/QtWebEngineProcess")))))
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 51af66ef54..bf1d45e5cc 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -538,7 +538,7 @@ interface.")
>                                        (assoc-ref inputs "qtwebengine")
>                                        "/lib/qt5/libexec/QtWebEngineProcess")))
>                 (wrap-program bin
> -                 `("QTWEBENGINEPROCESS_PATH" ":" prefix (,qt-process-path)))
> +                 `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path)))
>                 #t))))))
>      (home-page "https://qutebrowser.org/")
>      (synopsis "Minimal, keyboard-focused, vim-like web browser")

Thanks, I split this in to two commits, wrote commit messages and pushed
to master in f4d139d02f0b0404540b74f3249de050b519b880.

Chris
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 171 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.