GNU bug report logs - #44771
[PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44771 in the body.
You can then email your comments to 44771 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
Date: Fri, 20 Nov 2020 22:19:06 +0100

I've noticed that installing supercollider breaks qutebrowser. It happens
because QTWEBENGINEPROCESS_PATH is not a search path, but rather a full path
to a file.  So supercollider puts this var into the user profile and then
qutebrowser's wrapper incorrectly concatenates it with the path coming from
the qtwebengine dependency. Calibre package has the same defect.

Message #8 received at 44771 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 44771 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
Date: Sat, 21 Nov 2020 11:11:03 +0100

---
 gnu/packages/ebook.scm        | 2 +-
 gnu/packages/web-browsers.scm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index 1609a631b7..e80ad45383 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -281,7 +281,7 @@
                   (lambda (binary)
                     (wrap-program binary
                       ;; Make QtWebEngineProcess available.
-                      `("QTWEBENGINEPROCESS_PATH" ":" =
+                      `("QTWEBENGINEPROCESS_PATH" =
                         ,(list (string-append
                                 qtwebengine
                                 "/lib/qt5/libexec/QtWebEngineProcess")))))
diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 51af66ef54..bf1d45e5cc 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -538,7 +538,7 @@ interface.")
                                       (assoc-ref inputs "qtwebengine")
                                       "/lib/qt5/libexec/QtWebEngineProcess")))
                (wrap-program bin
-                 `("QTWEBENGINEPROCESS_PATH" ":" prefix (,qt-process-path)))
+                 `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path)))
                #t))))))
     (home-page "https://qutebrowser.org/")
     (synopsis "Minimal, keyboard-focused, vim-like web browser")
-- 
2.29.2

Message #13 received at 44771-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 44771-done <at> debbugs.gnu.org
Subject: Re: [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
Date: Sat, 28 Nov 2020 16:34:58 +0000

[Message part 1 (text/plain, inline)]

Sergey Trofimov <sarg <at> sarg.org.ru> writes:

> ---
>  gnu/packages/ebook.scm        | 2 +-
>  gnu/packages/web-browsers.scm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 1609a631b7..e80ad45383 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -281,7 +281,7 @@
>                    (lambda (binary)
>                      (wrap-program binary
>                        ;; Make QtWebEngineProcess available.
> -                      `("QTWEBENGINEPROCESS_PATH" ":" =
> +                      `("QTWEBENGINEPROCESS_PATH" =
>                          ,(list (string-append
>                                  qtwebengine
>                                  "/lib/qt5/libexec/QtWebEngineProcess")))))
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 51af66ef54..bf1d45e5cc 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -538,7 +538,7 @@ interface.")
>                                        (assoc-ref inputs "qtwebengine")
>                                        "/lib/qt5/libexec/QtWebEngineProcess")))
>                 (wrap-program bin
> -                 `("QTWEBENGINEPROCESS_PATH" ":" prefix (,qt-process-path)))
> +                 `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path)))
>                 #t))))))
>      (home-page "https://qutebrowser.org/")
>      (synopsis "Minimal, keyboard-focused, vim-like web browser")

Thanks, I split this in to two commits, wrote commit messages and pushed
to master in f4d139d02f0b0404540b74f3249de050b519b880.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.