GNU bug report logs - #44731
[PATCH] Make XEmacs compat aliases easy-menu-{add,remove} obsolete

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 19 Nov 2020 00:41:01 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #13 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44731 <at> debbugs.gnu.org
Subject: Re: bug#44731: [PATCH] Make XEmacs compat aliases easy-menu-{add,
 remove} obsolete
Date: Tue, 24 Nov 2020 09:14:38 -0800
tags 44731 fixed
close 44731 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> The `easy-menu-remove' and `easy-menu-add' are XEmacs compatibility
>> aliases.  I think they do not make sense these days, and it is better
>> for code that wants to use them to wrap the call in something like
>> `(when (featurep 'xemacs) ...)'.
>>
>> The attached patch makes them obsolete and fixes all callers.  It takes
>> care to not remove XEmacs compatibility from any modules where it was
>> not already removed, so I hope this will be uncontroversial.
>
> Makes sense to me.

Thanks.  No further comments within a week, so I pushed this to master
as commit affe9b225d.




This bug report was last modified 4 years and 271 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.