GNU bug report logs - #44731
[PATCH] Make XEmacs compat aliases easy-menu-{add,remove} obsolete

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44731 in the body.
You can then email your comments to 44731 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make XEmacs compat aliases easy-menu-{add,remove} obsolete
Date: Wed, 18 Nov 2020 16:40:27 -0800

[Message part 1 (text/plain, inline)]

Severity: wishlist

The `easy-menu-remove' and `easy-menu-add' are XEmacs compatibility
aliases.  I think they do not make sense these days, and it is better
for code that wants to use them to wrap the call in something like
`(when (featurep 'xemacs) ...)'.

The attached patch makes them obsolete and fixes all callers.  It takes
care to not remove XEmacs compatibility from any modules where it was
not already removed, so I hope this will be uncontroversial.

[0001-Make-XEmacs-compat-aliases-easy-menu-add-remove-obso.patch (text/x-diff, attachment)]

Message #8 received at 44731 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 44731 <at> debbugs.gnu.org
Subject: Re: bug#44731: [PATCH] Make XEmacs compat aliases
 easy-menu-{add,remove} obsolete
Date: Tue, 24 Nov 2020 09:00:58 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> The `easy-menu-remove' and `easy-menu-add' are XEmacs compatibility
> aliases.  I think they do not make sense these days, and it is better
> for code that wants to use them to wrap the call in something like
> `(when (featurep 'xemacs) ...)'.
>
> The attached patch makes them obsolete and fixes all callers.  It takes
> care to not remove XEmacs compatibility from any modules where it was
> not already removed, so I hope this will be uncontroversial.

Makes sense to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 44731 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44731 <at> debbugs.gnu.org
Subject: Re: bug#44731: [PATCH] Make XEmacs compat aliases easy-menu-{add,
 remove} obsolete
Date: Tue, 24 Nov 2020 09:14:38 -0800

tags 44731 fixed
close 44731 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> The `easy-menu-remove' and `easy-menu-add' are XEmacs compatibility
>> aliases.  I think they do not make sense these days, and it is better
>> for code that wants to use them to wrap the call in something like
>> `(when (featurep 'xemacs) ...)'.
>>
>> The attached patch makes them obsolete and fixes all callers.  It takes
>> care to not remove XEmacs compatibility from any modules where it was
>> not already removed, so I hope this will be uncontroversial.
>
> Makes sense to me.

Thanks.  No further comments within a week, so I pushed this to master
as commit affe9b225d.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.