GNU bug report logs - #44679
[PATCH] gnu: gst-plugins-bad: Enable webrtc module.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Mon, 16 Nov 2020 09:47:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Rohleder <mike <at> rohleder.de>
Subject: bug#44679: closed (Re: [bug#44679] [PATCH] gnu: gst-plugins-bad:
 Enable webrtc module.)
Date: Wed, 25 Nov 2020 13:11:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#44679: [PATCH] gnu: gst-plugins-bad: Enable webrtc module.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 44679 <at> debbugs.gnu.org.

-- 
44679: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44679
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 44679-done <at> debbugs.gnu.org
Subject: Re: [bug#44679] [PATCH] gnu: gst-plugins-bad: Enable webrtc module.
Date: Wed, 25 Nov 2020 14:09:52 +0100
Hello Michael,

> IMHO, it's very, very important that the free world does everything it
> could possibly do to support video conferencing, voip and so on
> with free software, asap.  Having a webrtc module in gstreamer could be
> an essential part of this (I came along the missing module while
> playing with nheko and voip calls over matrix...).
>
> I don't understand why the test for the curl module is failing now,
> so I disabled that also.

Thanks for fixing it, pushed as
933ddba223178fc2e530d5c9e3be1dd50a64ee95.

Mathieu

[Message part 3 (message/rfc822, inline)]
From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: gst-plugins-bad: Enable webrtc module.
Date: Mon, 16 Nov 2020 10:46:28 +0100
* gnu/packages/gstreamer.scm (gst-plugins-bad): Enable webrtc module.
[inputs]: Add libnice and webrtc-audio-processing.
[arguments]: Add substitution of failing tests.
---
IMHO, it's very, very important that the free world does everything it
could possibly do to support video conferencing, voip and so on
with free software, asap.  Having a webrtc module in gstreamer could be
an essential part of this (I came along the missing module while
playing with nheko and voip calls over matrix...).

I don't understand why the test for the curl module is failing now,
so I disabled that also.

 gnu/packages/gstreamer.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 01474e29a7..791bb98ec0 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -671,8 +672,9 @@ model to base your own plug-in on, here it is.")
            (lambda _
              ;; FIXME: Why is this failing.
              (substitute* "tests/check/meson.build"
-               ((".*elements/dash_mpd\\.c.*")
-                ""))
+               ((".*elements/dash_mpd\\.c.*") "")
+               ((".*elements/curlhttpsrc\\.c.*") "")
+               ((".*elements/webrtcbin\\.c.*") ""))
              #t)))))
     (propagated-inputs
      `(("gst-plugins-base" ,gst-plugins-base)))
@@ -702,6 +704,7 @@ model to base your own plug-in on, here it is.")
        ("libgudev" ,libgudev)
        ("libkate" ,libkate)
        ("libmodplug" ,libmodplug)
+       ("libnice" ,libnice)
        ("librsvg" ,librsvg)
        ("libsndfile" ,libsndfile)
        ("libsrtp" ,libsrtp)
@@ -726,6 +729,7 @@ model to base your own plug-in on, here it is.")
        ;; GStreamer is not yet compatible with srt > 1.4.1.
        ("srt" ,srt-1.4.1)
        ("x265" ,x265)
+       ("webrtc-audio-processing" ,webrtc-audio-processing)
        ("wayland" ,wayland)))
     (home-page "https://gstreamer.freedesktop.org/")
     (synopsis "Plugins for the GStreamer multimedia library")
-- 
2.29.2




This bug report was last modified 4 years and 257 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.