GNU bug report logs - #44679
[PATCH] gnu: gst-plugins-bad: Enable webrtc module.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44679 in the body.
You can then email your comments to 44679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: gst-plugins-bad: Enable webrtc module.
Date: Mon, 16 Nov 2020 10:46:28 +0100

* gnu/packages/gstreamer.scm (gst-plugins-bad): Enable webrtc module.
[inputs]: Add libnice and webrtc-audio-processing.
[arguments]: Add substitution of failing tests.
---
IMHO, it's very, very important that the free world does everything it
could possibly do to support video conferencing, voip and so on
with free software, asap.  Having a webrtc module in gstreamer could be
an essential part of this (I came along the missing module while
playing with nheko and voip calls over matrix...).

I don't understand why the test for the curl module is failing now,
so I disabled that also.

 gnu/packages/gstreamer.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 01474e29a7..791bb98ec0 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -671,8 +672,9 @@ model to base your own plug-in on, here it is.")
            (lambda _
              ;; FIXME: Why is this failing.
              (substitute* "tests/check/meson.build"
-               ((".*elements/dash_mpd\\.c.*")
-                ""))
+               ((".*elements/dash_mpd\\.c.*") "")
+               ((".*elements/curlhttpsrc\\.c.*") "")
+               ((".*elements/webrtcbin\\.c.*") ""))
              #t)))))
     (propagated-inputs
      `(("gst-plugins-base" ,gst-plugins-base)))
@@ -702,6 +704,7 @@ model to base your own plug-in on, here it is.")
        ("libgudev" ,libgudev)
        ("libkate" ,libkate)
        ("libmodplug" ,libmodplug)
+       ("libnice" ,libnice)
        ("librsvg" ,librsvg)
        ("libsndfile" ,libsndfile)
        ("libsrtp" ,libsrtp)
@@ -726,6 +729,7 @@ model to base your own plug-in on, here it is.")
        ;; GStreamer is not yet compatible with srt > 1.4.1.
        ("srt" ,srt-1.4.1)
        ("x265" ,x265)
+       ("webrtc-audio-processing" ,webrtc-audio-processing)
        ("wayland" ,wayland)))
     (home-page "https://gstreamer.freedesktop.org/")
     (synopsis "Plugins for the GStreamer multimedia library")
-- 
2.29.2

Message #10 received at 44679-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 44679-done <at> debbugs.gnu.org
Subject: Re: [bug#44679] [PATCH] gnu: gst-plugins-bad: Enable webrtc module.
Date: Wed, 25 Nov 2020 14:09:52 +0100

Hello Michael,

> IMHO, it's very, very important that the free world does everything it
> could possibly do to support video conferencing, voip and so on
> with free software, asap.  Having a webrtc module in gstreamer could be
> an essential part of this (I came along the missing module while
> playing with nheko and voip calls over matrix...).
>
> I don't understand why the test for the curl module is failing now,
> so I disabled that also.

Thanks for fixing it, pushed as
933ddba223178fc2e530d5c9e3be1dd50a64ee95.

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.