GNU bug report logs - #44651
[PATCH] Silence byte-compiler warning

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> mailfence.com>

Date: Sun, 15 Nov 2020 02:40:01 UTC

Severity: normal

Tags: fixed, moreinfo, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 44651 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, akrl <at> sdf.org
Cc: 44651 <at> debbugs.gnu.org
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
Date: Tue, 17 Nov 2020 00:52:41 +0100 (CET)
> I don't think that should be necessary?  The function in question is
> autoloaded:
> 
> ;;;###autoload
> 
> Where/when do you see this compilation warning?

I noticed this on the feature/native-comp branch, after invoking `helm-man-woman` and having woman.el native-compiled asynchronously. I don't have the log.

I did not notice that it was autoloaded. Andrea, are you aware of any issues that the native-comp branch may have with this kind of thing (autoloaded functions defined in files that do not necessarily get REQUIRE-d)? If not, maybe we can just ignore my patch.

Thanks,
Brian

> ----------------------------------------
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Sent: Mon Nov 16 23:46:05 CET 2020
> To: Brian Leung <leungbk <at> mailfence.com>
> Cc: <44651 <at> debbugs.gnu.org>
> Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
> 
> 
> Brian Leung <leungbk <at> mailfence.com> writes:
> 
> > See attached.
> 
> [...]
> 
> > * lisp/woman.el: Declare imenu-add-to-menubar.
> 
> I don't think that should be necessary?  The function in question is
> autoloaded:
> 
> ;;;###autoload
> (defun imenu-add-to-menubar (name)
> 
> Where/when do you see this compilation warning?
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no


-- 
Sent with https://mailfence.com
Secure and private email




This bug report was last modified 4 years and 156 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.