GNU bug report logs - #44650
Do not suggest `guix pull --news' after first pull

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44650 in the body.
You can then email your comments to 44650 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: bug-guix <at> gnu.org
Subject: Do not suggest `guix pull --news' after first pull
Date: Sun, 15 Nov 2020 02:56:30 +0100

[Message part 1 (text/plain, inline)]

After doing a `guix pull` on the new VM image
<https://alpha.gnu.org/gnu/guix/guix-system-vm-image-1.2.0rc1.x86_64-linux.xz>,
the following is displayed:

> hint: Run `guix pull --news' to read all the news.
> 
> hint: After setting `PATH', run `hash guix' to make sure your shell refers to `/home/guest/.config/guix/current/bin/guix'.

The former `guix pull --news` is without effect (it is the very first
time I did a `guix pull`).  It is a no-op.  Users should not get the
suggestion to run `guix pull --news`.


Within (guix scripts pull)’ build-and-install procedure, the value of
(display-channel-news-headlines profile) is <unspecified>.

The attached patch changes it to return #f.  I have verified running
`guix pull --news' is not suggested anymore with it (although I have
not tested if news are still displayed).

It would perhaps be nicer if the news since version 1.2.0 were
displayed, but I do not know how to make it so.  I guess since the
original guix package must come from the guix package in (gnu packages
package-management), it is impossible to determine the version from
which news should be computed.

Regards,
Florian

[0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch (text/plain, attachment)]

Message #8 received at 44650 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: 44650 <at> debbugs.gnu.org
Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull
Date: Sun, 15 Nov 2020 16:17:17 +0100

[Message part 1 (text/plain, inline)]

On Sun, Nov 15, 2020 at 02:56:30AM +0100, pelzflorian (Florian Pelz) wrote:
> -  (when previous
> +  (if previous
>      (let ((old-channels (profile-channels previous))
>            (new-channels (profile-channels profile)))
>        ;; Find the channels present in both PROFILE and PREVIOUS, and print
> @@ -405,7 +405,8 @@ previous generation.  Return true if there are news to display."
>                                                        #:concise? #t)))
>                      channels))
>  
> -             (any ->bool more?))))))
> +             (any ->bool more?))))
> +    #f))

I changed the patch to use `and` instead of `if` (attached).  I
confirmed that channel news display fine on a later `guix pull`.

Should I add a copyright line?  I believe no.

Regards,
Florian

[0001-pull-Do-not-suggest-running-guix-pull-news-on-the-fi.patch (text/plain, attachment)]

Message #11 received at 44650 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 44650 <at> debbugs.gnu.org
Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull
Date: Mon, 16 Nov 2020 12:35:08 +0100

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> skribis:

> Should I add a copyright line?  I believe no.

Yeah, probably not.

> From 8b1557004f618a47d4bea3a65a5b88c4cb718c4c Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian <at> pelzflorian.de>
> Date: Sat, 14 Nov 2020 23:36:52 +0100
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> Subject: [PATCH] pull: Do not suggest running `guix pull --news' on the first
>  run.
>
> * guix/scripts/pull.scm (display-channel-news-headlines): If there
> are no news to display, return false instead of <unspecified>.

Perfect, you can push to ‘version-1.2.0’, thank you!

Ludo’.

Message #16 received at 44650-done <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44650-done <at> debbugs.gnu.org
Subject: Re: bug#44650: Do not suggest `guix pull --news' after first pull
Date: Mon, 16 Nov 2020 14:55:51 +0100

On Mon, Nov 16, 2020 at 12:35:08PM +0100, Ludovic Courtès wrote:
> Perfect, you can push to ‘version-1.2.0’, thank you!
> 
> Ludo’.

Thank you.  Pushed as 29ed17d6345d30b0646f0a9b63ab201e0e6871ec.  Done.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.