GNU bug report logs - #44620
[PATCH] gnu: Add gmni.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44620 in the body.
You can then email your comments to 44620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: guix-patches <at> gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Subject: [PATCH] gnu: Add gmni.
Date: Fri, 13 Nov 2020 18:51:52 +0200

* gnu/packages/web-browsers.scm (gmni): New variable.
---
 gnu/packages/web-browsers.scm | 44 +++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 5cb5185a31..b959825464 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -13,6 +13,7 @@
 ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
 ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
+;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -60,6 +61,7 @@
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages lisp-xyz)
   #:use-module (gnu packages lua)
+  #:use-module (gnu packages man)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -584,6 +586,48 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
 (define-public sbcl-next
   (deprecated-package "sbcl-next" nyxt))
 
+(define-public gmni
+  (let ((commit "4a6172f1bf9cb41eb1ce3a5f720f9ebe4febc62b")
+        (revision "0"))
+    (package
+      (name "gmni")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~sircmpwn/gmni")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1nznkk1ccm5l09glalkv8bmhspqhvmh74ca18cfpdpbwkbzdzc7i"))
+                (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f
+         #:phases
+         (modify-phases %standard-phases
+           (add-before 'configure 'set-variables
+             (lambda _
+               (setenv "CC" "gcc")
+               #t)))))
+      (inputs
+       `(("openssl" ,openssl)))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("scdoc" ,scdoc)))
+      (home-page "https://sr.ht/~sircmpwn/gmni")
+      (synopsis "Gemini client")
+      (description "This is a Gemini client.  Included are:
+
+@itemize
+@item A CLI utility (like curl): gmni
+@item A line-mode browser: gmnlm
+@end itemize")
+      (license (list license:gpl3+
+                     (license:non-copyleft
+                      "https://curl.se/docs/copyright.html"
+                      "Used only for files taken from curl."))))))
+
 (define-public bombadillo
   (package
     (name "bombadillo")
-- 
2.29.1

Message #8 received at 44620 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: 44620 <at> debbugs.gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Subject: [PATCH v2] gnu: Add gmni.
Date: Fri, 13 Nov 2020 19:02:01 +0200

* gnu/packages/web-browsers.scm (gmni): New variable.
---
This second version simplifies the arguments section by using #:make-flags to
set CC, rather than using an environment variable.

 gnu/packages/web-browsers.scm | 39 +++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 5cb5185a31..b652e8d472 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -13,6 +13,7 @@
 ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
 ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
+;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -60,6 +61,7 @@
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages lisp-xyz)
   #:use-module (gnu packages lua)
+  #:use-module (gnu packages man)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -584,6 +586,43 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
 (define-public sbcl-next
   (deprecated-package "sbcl-next" nyxt))
 
+(define-public gmni
+  (let ((commit "4a6172f1bf9cb41eb1ce3a5f720f9ebe4febc62b")
+        (revision "0"))
+    (package
+      (name "gmni")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~sircmpwn/gmni")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1nznkk1ccm5l09glalkv8bmhspqhvmh74ca18cfpdpbwkbzdzc7i"))
+                (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f
+         #:make-flags (list "CC=gcc")))
+      (inputs
+       `(("openssl" ,openssl)))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("scdoc" ,scdoc)))
+      (home-page "https://sr.ht/~sircmpwn/gmni")
+      (synopsis "Gemini client")
+      (description "This is a Gemini client.  Included are:
+
+@itemize
+@item A CLI utility (like curl): gmni
+@item A line-mode browser: gmnlm
+@end itemize")
+      (license (list license:gpl3+
+                     (license:non-copyleft
+                      "https://curl.se/docs/copyright.html"
+                      "Used only for files taken from curl."))))))
+
 (define-public bombadillo
   (package
     (name "bombadillo")
-- 
2.29.1

Message #11 received at 44620 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 44620 <at> debbugs.gnu.org
Subject: Re: [bug#44620] [PATCH v2] gnu: Add gmni.
Date: Sun, 15 Nov 2020 19:23:49 +0000

[Message part 1 (text/plain, inline)]

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> writes:

> * gnu/packages/web-browsers.scm (gmni): New variable.

Hi,

Thanks for the patch :) I've made some comments below.

> ---
> This second version simplifies the arguments section by using #:make-flags to
> set CC, rather than using an environment variable.
>
>  gnu/packages/web-browsers.scm | 39 +++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 5cb5185a31..b652e8d472 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -13,6 +13,7 @@
>  ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
>  ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
>  ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
> +;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -60,6 +61,7 @@
>    #:use-module (gnu packages lisp)
>    #:use-module (gnu packages lisp-xyz)
>    #:use-module (gnu packages lua)
> +  #:use-module (gnu packages man)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
> @@ -584,6 +586,43 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
>  (define-public sbcl-next
>    (deprecated-package "sbcl-next" nyxt))
>  
> +(define-public gmni
> +  (let ((commit "4a6172f1bf9cb41eb1ce3a5f720f9ebe4febc62b")
> +        (revision "0"))
> +    (package
> +      (name "gmni")
> +      (version (git-version "0" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://git.sr.ht/~sircmpwn/gmni")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1nznkk1ccm5l09glalkv8bmhspqhvmh74ca18cfpdpbwkbzdzc7i"))
> +                (file-name (git-file-name name version))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f

I'm guessing there are no tests to run, but a comment saying that would
be good.

> +         #:make-flags (list "CC=gcc")))

I think it would be better to put something like:

  (string-append "CC=" ,(cc-for-target))

As I believe that helps when compiling for other architectures. I copied
that from the f3 package if you want an example in context.

> +      (inputs
> +       `(("openssl" ,openssl)))
> +      (native-inputs
> +       `(("pkg-config" ,pkg-config)
> +         ("scdoc" ,scdoc)))
> +      (home-page "https://sr.ht/~sircmpwn/gmni")
> +      (synopsis "Gemini client")

Is there some way of making this more descriptive, like saying it's a
command line client?

> +      (description "This is a Gemini client.  Included are:
> +
> +@itemize
> +@item A CLI utility (like curl): gmni
> +@item A line-mode browser: gmnlm
> +@end itemize")

I'd probably change the start of this to "The gmni package includes:",
as that repeats the synopsis less.

> +      (license (list license:gpl3+
> +                     (license:non-copyleft
> +                      "https://curl.se/docs/copyright.html"
> +                      "Used only for files taken from curl."))))))
> +
>  (define-public bombadillo
>    (package
>      (name "bombadillo")

Would you be able to send an updated patch?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 44620 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 44620 <at> debbugs.gnu.org
Subject: Re: [bug#44620] [PATCH v2] gnu: Add gmni.
Date: Mon, 16 Nov 2020 21:55:32 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Hi Chris,

Thank you for all the tips!

15 Nov 2020 21:24:02 Christopher Baines <mail <at> cbaines.net>:

> Would you be able to send an updated patch?

I will, but probably sometime later this week, as I'm currently caught in 
other stuff.

Cheers,
Sergiu

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 44620 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: Christopher Baines <mail <at> cbaines.net>, 44620 <at> debbugs.gnu.org
Subject: Re: [bug#44620] [PATCH v2] gnu: Add gmni.
Date: Sun, 29 Nov 2020 23:30:39 +0100

Hi Sergiu,

Did you have a chance to look into it?

Thanks in advance,
Ludo’.

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> skribis:

> Hi Chris,
>
> Thank you for all the tips!
>
> 15 Nov 2020 21:24:02 Christopher Baines <mail <at> cbaines.net>:
>
>> Would you be able to send an updated patch?
>
> I will, but probably sometime later this week, as I'm currently caught
> in other stuff.
>
> Cheers,
> Sergiu

Message #20 received at 44620 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: 44620 <at> debbugs.gnu.org
Cc: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>,
 Ludovic Courtes <ludo <at> gnu.org>, Christopher Baines <mail <at> cbaines.net>
Subject: [PATCH v3] gnu: Add gmni.
Date: Mon, 30 Nov 2020 11:50:41 +0200

* gnu/packages/web-browsers.scm (gmni): New variable.
---
This new patch version should take into account the comments provided by
Christopher. It also uses a newer commit for gmni and should fix some
conflicts when applying it to the guix repository.

Sorry for the delay!

 gnu/packages/web-browsers.scm | 40 +++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 7fe890502e..b101b78008 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo <at> nixo.xyz>
+;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,6 +42,7 @@
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
+  #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages compression)
@@ -62,6 +64,7 @@
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages lisp-xyz)
   #:use-module (gnu packages lua)
+  #:use-module (gnu packages man)
   #:use-module (gnu packages markup)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
@@ -706,6 +709,43 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
 (define-public sbcl-next
   (deprecated-package "sbcl-next" nyxt))
 
+(define-public gmni
+  (let ((commit "d8f0870446c471a42612d6a8e853ad9b723a6d39")
+        (revision "0"))
+    (package
+      (name "gmni")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~sircmpwn/gmni")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1h0iqm7l0i06glf5b2872w656s1mjdiqva14zh6sl4f5yp7zmvwr"))
+                (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; no check target
+         #:make-flags (list (string-append "CC=" ,(cc-for-target)))))
+      (inputs
+       `(("openssl" ,openssl)))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("scdoc" ,scdoc)))
+      (home-page "https://sr.ht/~sircmpwn/gmni")
+      (synopsis "Minimalist command line Gemini client")
+      (description "The gmni package includes:
+
+@itemize
+@item A CLI utility (like curl): gmni
+@item A line-mode browser: gmnlm
+@end itemize")
+      (license (list license:gpl3+
+                     (license:non-copyleft
+                      "https://curl.se/docs/copyright.html"
+                      "Used only for files taken from curl."))))))
+
 (define-public bombadillo
   (package
     (name "bombadillo")
-- 
2.29.2

Message #25 received at 44620-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
Cc: 44620-done <at> debbugs.gnu.org, Ludovic Courtes <ludo <at> gnu.org>
Subject: Re: [PATCH v3] gnu: Add gmni.
Date: Mon, 30 Nov 2020 09:34:32 +0000

[Message part 1 (text/plain, inline)]

Alexandru-Sergiu Marton <brown121407 <at> posteo.ro> writes:

> * gnu/packages/web-browsers.scm (gmni): New variable.
> ---
> This new patch version should take into account the comments provided by
> Christopher. It also uses a newer commit for gmni and should fix some
> conflicts when applying it to the guix repository.
>
> Sorry for the delay!

No problem! The patch looks good, I've pushed to master as
6e4f62ad8fe0a1bafee4b318ad81152b7e425d4f.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.