GNU bug report logs - #44619
[PATCH] Expose some functions for guix.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44619 in the body.
You can then email your comments to 44619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: bug-guix <at> gnu.org
Subject: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 05:54:08 -0800

[Message part 1 (text/plain, inline)]

Hi Guix,

guix.el Has been broken for quite some time because it depends on @@ for
some modules.  After some review, I came to the conclusion that all of
the bindings it uses can be safely exposed.

In general, it uses mostly bindings from guix scripts (pack, build,
etc).  Those bindings seem reasonable to expose since they give
programmatic access to "API"s that the CLI user is most likely familiar
with.

Thanks!

John

[0001-guix-pack-Expose-some-bindings-for-third-party-use.patch (text/x-patch, attachment)]

[0002-guix-build-Expose-log-url-for-third-parties.patch (text/x-patch, attachment)]

Message #8 received at 44619 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: John Soo <jsoo1 <at> asu.edu>, 44619 <at> debbugs.gnu.org
Subject: Re: bug#44619: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 16:58:38 +0100

Hi John,

Thank you for raising this.


> diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
> index 8e694edbbe..b6dfcb5f6a 100644
> --- a/guix/scripts/pack.scm
> +++ b/guix/scripts/pack.scm
> @@ -58,11 +58,14 @@
>    #:use-module (srfi srfi-37)
>    #:use-module (ice-9 match)
>    #:export (compressor?
> +            compressor-name

Why not also ’compress-extension’ and ’compress-command’?  Then
<compressor> will be completely exposed which seems good, isn’t it?


All the best,
simon

Message #11 received at 44619 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 44619 <at> debbugs.gnu.org
Subject: Re: bug#44619: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 08:11:04 -0800

[Message part 1 (text/plain, inline)]

Hi zimoun,

zimoun <zimon.toutoune <at> gmail.com> writes:

>> diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
>> index 8e694edbbe..b6dfcb5f6a 100644
>> --- a/guix/scripts/pack.scm
>> +++ b/guix/scripts/pack.scm
>> @@ -58,11 +58,14 @@
>>    #:use-module (srfi srfi-37)
>>    #:use-module (ice-9 match)
>>    #:export (compressor?
>> +            compressor-name
>
> Why not also ’compress-extension’ and ’compress-command’?  Then
> <compressor> will be completely exposed which seems good, isn’t it?

Done, thank you!

All the best to you, too,

John

[0001-guix-pack-Expose-some-bindings-for-third-party-use.patch (text/x-patch, attachment)]

[0002-guix-build-Expose-log-url-for-third-parties.patch (text/x-patch, attachment)]

Message #14 received at 44619 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 44619 <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#44619: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 18:13:33 +0100

Hi John,

John Soo <jsoo1 <at> asu.edu> skribis:

> From 7f718484fe952b674c2cdaa70315d49df3c8aa57 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Thu, 12 Nov 2020 21:47:36 -0800
> Subject: [PATCH 1/2] guix pack: Expose some bindings for third-party use.
>
> * guix/scripts/pack.scm (compressor-name, compressor-extension,
> compressor-command, %compressors, %formats):
> Expose them.

[...]

> From 036dc16855c9a3f3022598c700f5e8233022aee1 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Thu, 12 Nov 2020 21:54:45 -0800
> Subject: [PATCH 2/2] guix build: Expose log-url for third parties.
>
> * guix/scripts/build.scm (log-url): Expose it.

Applied both to ‘version-1.2.0’, which we’ll eventually merge back to
‘master’.

In general, code outside the repo should not use ‘@@’ at all to refer to
Guix internals; we should ensure this is the case for Emacs-Guix.

Actually, even code within Guix should avoid it.  :-)

Thanks!

Ludo’.

Message #17 received at 44619 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44619 <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#44619: [PATCH] Expose some functions for guix.el
Date: Fri, 13 Nov 2020 09:17:22 -0800

Ludovic Courtès <ludo <at> gnu.org> writes:

> In general, code outside the repo should not use ‘@@’ at all to refer to
> Guix internals; we should ensure this is the case for Emacs-Guix.
>
> Actually, even code within Guix should avoid it.  :-)

Indeed. I submitted some patches to emacs-guix to remedy this:

https://gitlab.com/emacs-guix/emacs-guix/-/merge_requests/8 

Thanks!

- John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.