GNU bug report logs - #44555
[PATCH] gnu: Add emacs-next-use-package

Previous Next

Full log

Message #26 received at 44555 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 44555 <at> debbugs.gnu.org
Subject: Re: [bug#44555] [PATCH] gnu: Add emacs-next-use-package
Date: Tue, 10 Nov 2020 21:32:24 +0100

[Message part 1 (text/plain, inline)]

Andrew Tropin <andrew <at> trop.in> writes:
> There is no issue with diminish itself. I just don't know why it
> is specified as propagated-input. It's an optional dependency as
> well as delight, key-chord and many other use-package extensions
> and it should be installed explicitly by the user, not pulled as a
> dependency.
>
> Probably I had to do it with another patch to make it clearer.

Normally, we try to install optional packages per default.
Sometimes, it's not so easy and one has to weigh up...

Maybe the use-case for use-package is so that diminish is very often
needed?  Or for too many users, it would be "useless" (or break
something), w/o it?


Imho (I don't have commit superpower), you need a reason to remove an
input (and here, this means provided/out of the box experience).  Or at
least make a comment in the source _why_ it isn't needed etc...


-- 
If you can't make it good, make it LOOK good. - Bill Gates

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.