GNU bug report logs -
#44555
[PATCH] gnu: Add emacs-next-use-package
Previous Next
Reported by: Andrew Tropin <andrew <at> trop.in>
Date: Tue, 10 Nov 2020 16:00:02 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44555 in the body.
You can then email your comments to 44555 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 16:00:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Andrew Tropin <andrew <at> trop.in>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 10 Nov 2020 16:00:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
use-package version 2.4 doesn't work with emacs-next (28), but there is no
other new tags in upstream repository. The last one is 2.4 and it was created
in Nov 2018. Other GNU/Linux distros uses more recent, but untagged
revision. This commit does the same.
Additionally, it removes diminish from propagated-inputs because this dependency
is optional. The only required dependencies are emacs and bind-key.
---
gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ff546506e9..3fe14a210a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11172,6 +11172,24 @@ configuration in your @file{.emacs} file in a
way that is both
performance-oriented and tidy.")
(license license:gpl2+)))
+(define-public emacs-next-use-package
+ (let ((commit "4fb1f9a68f1e7e7d614652afc017a6652fd029f1")
+ (revision "20200721"))
+ (package/inherit emacs-use-package
+ (name "emacs-next-use-package")
+ (version (git-version "2.4" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jwiegley/use-package")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "073sm0mbxcjysap2bjzf1cl0134jy8a0xig7ywmmd0bm2y8qzfip"))))
+ (propagated-inputs '()))))
+
(define-public emacs-leaf
(package
(name "emacs-leaf")
--
2.25.4
--
Best regards,
Andrew Tropin
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 17:17:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 44555 <at> debbugs.gnu.org (full text, mbox):
Dear,
On Tue, 10 Nov 2020 at 17:13, Andrew Tropin <andrew <at> trop.in> wrote:
> +(define-public emacs-next-use-package
> + (let ((commit "4fb1f9a68f1e7e7d614652afc017a6652fd029f1")
> + (revision "20200721"))
> + (package/inherit emacs-use-package
> + (name "emacs-next-use-package")
> + (version (git-version "2.4" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/jwiegley/use-package")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "073sm0mbxcjysap2bjzf1cl0134jy8a0xig7ywmmd0bm2y8qzfip"))))
> + (propagated-inputs '()))))
> +
Maybe I am missing something, but it is not built using 'emacs-next'.
Why not simply update the package 'emacs-use-package' with a comment
explaining what you already explained?
All the best,
simon
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 17:50:03 GMT)
Full text and
rfc822 format available.
Message #11 received at 44555 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
The email client breaks indentation, will try to attach the patch to
this message.
--
Best regards,
Andrew Tropin
[0001-gnu-Add-emacs-next-use-package.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 17:57:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 44555 <at> debbugs.gnu.org (full text, mbox):
> Maybe I am missing something, but it is not built using 'emacs-next'.
> Why not simply update the package 'emacs-use-package' with a comment
> explaining what you already explained?
It's true, it's built with emacs-minimal and probably the name is
a little confusing in that sense.
The original idea was to just update current emacs-use-package,
but during discussion in #guix leoprikler mentioned that
emacs-use-package works fine for users of Emacs 27 and because
the revision I picked is not a stable tag, but just a fresh
commit of use-package and I do it to make people able to use it
from Emacs 28 it would be logical to create a separate package
and keep stable 2.4 version for other users.
Also, removing diminish from propagated inputs can break
someone's setup.
My original patch was: http://ix.io/2DDt
I think it should be safe to just update emacs-use-package to the
more recent revision. It will work for both 27 and 28 users.
Let me know what you think and what you advise to do next.
--
Best regards,
Andrew Tropin
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 18:01:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 44555 <at> debbugs.gnu.org (full text, mbox):
Hello zimoun,
it was me, who suggested (in IRC) to keep two different packages, as it
appeared to me to be a non-trivial transaction (given the changes to
propagated-inputs) with the intent to make things run on Emacs 28. I
did try to point out, that it can/should be built with Emacs 28, but
there appears to have been some miscommunication.
Regards,
Leo
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 19:23:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 44555 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
zimoun <zimon.toutoune <at> gmail.com> writes:
> Maybe I am missing something, but it is not built using 'emacs-next'.
> Why not simply update the package 'emacs-use-package' with a comment
> explaining what you already explained?
If this package doesn't work with emacs28 as it is, I also think
it is good/ok to bump it to a non release commit.
But why also remove propagated-inputs (diminish)?
I use diminish with emacs28 w/o trouble.
diminish is a very small and clean package/sources (and very funny to
read, *love it*).
Maybe we need to debug this better/harder to find the (real) issue?
Andrew, do you have any error message/debug output for the combination
use-package/diminish with emacs28?
--
Hard work never killed anybody, but why take a chance?
Charlie McCarthy
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 19:37:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 44555 <at> debbugs.gnu.org (full text, mbox):
> But why also remove propagated-inputs (diminish)?
> I use diminish with emacs28 w/o trouble.
> diminish is a very small and clean package/sources (and very funny to
> read, *love it*).
There is no issue with diminish itself. I just don't know why it
is specified as propagated-input. It's an optional dependency as
well as delight, key-chord and many other use-package extensions
and it should be installed explicitly by the user, not pulled as a
dependency.
Probably I had to do it with another patch to make it clearer.
--
Best regards,
Andrew Tropin
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Tue, 10 Nov 2020 20:33:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 44555 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Andrew Tropin <andrew <at> trop.in> writes:
> There is no issue with diminish itself. I just don't know why it
> is specified as propagated-input. It's an optional dependency as
> well as delight, key-chord and many other use-package extensions
> and it should be installed explicitly by the user, not pulled as a
> dependency.
>
> Probably I had to do it with another patch to make it clearer.
Normally, we try to install optional packages per default.
Sometimes, it's not so easy and one has to weigh up...
Maybe the use-case for use-package is so that diminish is very often
needed? Or for too many users, it would be "useless" (or break
something), w/o it?
Imho (I don't have commit superpower), you need a reason to remove an
input (and here, this means provided/out of the box experience). Or at
least make a comment in the source _why_ it isn't needed etc...
--
If you can't make it good, make it LOOK good. - Bill Gates
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Wed, 11 Nov 2020 07:55:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 44555 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Cool news: John Wiegley made a new release a few hours ago, my patch is no
longer relevant, will make another one, which just bumps the version to
2.4.1.
> Normally, we try to install optional packages per default.
> Sometimes, it's not so easy and one has to weigh up...
>
> Maybe the use-case for use-package is so that diminish is very often
> needed? Or for too many users, it would be "useless" (or break
> something), w/o it?
>
>
> Imho (I don't have commit superpower), you need a reason to remove an
> input (and here, this means provided/out of the box experience). Or at
> least make a comment in the source _why_ it isn't needed etc...
I will give you a simple example: Someone uses delight (a diminish
alternative, which also support major modes) instead of diminish and
they would install emacs-use-package and emacs-delight, but he will also
get emacs-diminsh as a dependency of emacs-use-package. To remove it
they will need to inherit emacs-use-package and update
propagated-inputs.
I think installing emacs-use-package and manually adding emacs-diminish
is easier and more fair than installing emacs-use-package+emacs-delight
and removing emacs-diminish from dependencies of emacs-use-package.
I totally agree, that diminish is a great package with a great story
inside its sources, but don't think it should be installed by default
with use-package.
I'll make a separate patch for removing propagated-inputs and related
discussion.
Bump patch in the attachment.
--
Best regards,
Andrew Tropin
[0001-gnu-emacs-use-package-Update-to-2.4.1.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Wed, 11 Nov 2020 09:37:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 44555 <at> debbugs.gnu.org (full text, mbox):
Hello,
Andrew Tropin <andrew <at> trop.in> writes:
> I will give you a simple example: Someone uses delight (a diminish
> alternative, which also support major modes) instead of diminish and
> they would install emacs-use-package and emacs-delight, but he will also
> get emacs-diminsh as a dependency of emacs-use-package. To remove it
> they will need to inherit emacs-use-package and update
> propagated-inputs.
I don't understand something here. Why would you have to remove Diminsh
in order to use Delight? Can't you have both in "site-lisp" and use
whichever you want?
Regards,
--
Nicolas Goaziou
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
:
You have taken responsibility.
(Wed, 11 Nov 2020 10:03:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Andrew Tropin <andrew <at> trop.in>
:
bug acknowledged by developer.
(Wed, 11 Nov 2020 10:03:03 GMT)
Full text and
rfc822 format available.
Message #37 received at 44555-done <at> debbugs.gnu.org (full text, mbox):
Hello,
Andrew Tropin <andrew <at> trop.in> writes:
> Cool news: John Wiegley made a new release a few hours ago, my patch is no
> longer relevant, will make another one, which just bumps the version to
> 2.4.1.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Wed, 11 Nov 2020 14:34:02 GMT)
Full text and
rfc822 format available.
Message #40 received at 44555-done <at> debbugs.gnu.org (full text, mbox):
> Applied. Thank you.
Thanks a lot!
Thank you everyone for help!
--
Best regards,
Andrew Tropin
Information forwarded
to
guix-patches <at> gnu.org
:
bug#44555
; Package
guix-patches
.
(Wed, 11 Nov 2020 22:49:02 GMT)
Full text and
rfc822 format available.
Message #43 received at 44555 <at> debbugs.gnu.org (full text, mbox):
Dear,
On Tue, 10 Nov 2020 at 19:00, Leo Prikler <leo.prikler <at> student.tugraz.at> wrote:
> it was me, who suggested (in IRC) to keep two different packages, as it
> appeared to me to be a non-trivial transaction (given the changes to
> propagated-inputs) with the intent to make things run on Emacs 28. I
> did try to point out, that it can/should be built with Emacs 28, but
> there appears to have been some miscommunication.
Thank you both for the explanations. Well, the fix has finally been
from upstream, if I read correctly. :-)
However, Guix is still missing a good story to build the Emacs packages
using ’emacs-minimal’ or ’emacs-next’ or any other elisp bytecode
compiler (emacs-guile, REmacs, emacs-gccjit, etc.).
All the best,
simon
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 10 Dec 2020 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 243 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.