GNU bug report logs - #44534
[PATCH] Remove extra process call from vc-hg-registered

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tom Fitzhenry <tomfitzhenry <at> google.com>
Subject: bug#44534: closed (Re: bug#44534: [PATCH] Remove extra process
 call from vc-hg-registered)
Date: Tue, 10 Nov 2020 15:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#44534: [PATCH] Remove extra process call from vc-hg-registered

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 44534 <at> debbugs.gnu.org.

-- 
44534: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44534
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Fitzhenry <tomfitzhenry <at> google.com>, 44534-done <at> debbugs.gnu.org
Subject: Re: bug#44534: [PATCH] Remove extra process call from vc-hg-registered
Date: Tue, 10 Nov 2020 17:45:28 +0200

Version: 28.1

On 09.11.2020 13:54, Tom Fitzhenry via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Prefer calling vc-state (rather than vc-hg-state) to benefit from the 
> caching in vc-state.
> 
> This same technique is used in vc-git.el, per commit "2018-06-28 "Remove 
> extra process call from vc-git-find-file-hook" 
> 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.

Makes sense, thanks! Pushed.

P.S. Next time please try to keep the line width within usual limits, I 
had to fix the following linter errors:

Line longer than 78 characters in commit message
Word longer than 140 characters in commit message
Commit aborted; please see the file CONTRIBUTE

[Message part 3 (message/rfc822, inline)]

From: Tom Fitzhenry <tomfitzhenry <at> google.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove extra process call from vc-hg-registered
Date: Mon, 9 Nov 2020 11:54:09 +0000

[Message part 4 (text/plain, inline)]

Prefer calling vc-state (rather than vc-hg-state) to benefit from the
caching in vc-state.

This same technique is used in vc-git.el, per commit "2018-06-28 "Remove
extra process call from vc-git-find-file-hook"
93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.

[Message part 5 (text/html, inline)]

[0001-Remove-extra-process-call-from-vc-hg-registered.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.