GNU bug report logs - #44534
[PATCH] Remove extra process call from vc-hg-registered

Previous Next

Package: emacs;

Reported by: Tom Fitzhenry <tomfitzhenry <at> google.com>

Date: Mon, 9 Nov 2020 15:26:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44534 in the body.
You can then email your comments to 44534 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44534; Package emacs. (Mon, 09 Nov 2020 15:26:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Tom Fitzhenry <tomfitzhenry <at> google.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 09 Nov 2020 15:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Fitzhenry <tomfitzhenry <at> google.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove extra process call from vc-hg-registered
Date: Mon, 9 Nov 2020 11:54:09 +0000

[Message part 1 (text/plain, inline)]
Prefer calling vc-state (rather than vc-hg-state) to benefit from the
caching in vc-state.

This same technique is used in vc-git.el, per commit "2018-06-28 "Remove
extra process call from vc-git-find-file-hook"
93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.

[Message part 2 (text/html, inline)]
[0001-Remove-extra-process-call-from-vc-hg-registered.patch (text/x-patch, attachment)]
Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Tue, 10 Nov 2020 15:46:02 GMT) Full text and rfc822 format available.
Notification sent to Tom Fitzhenry <tomfitzhenry <at> google.com>:
bug acknowledged by developer. (Tue, 10 Nov 2020 15:46:02 GMT) Full text and rfc822 format available.

Message #10 received at 44534-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Fitzhenry <tomfitzhenry <at> google.com>, 44534-done <at> debbugs.gnu.org
Subject: Re: bug#44534: [PATCH] Remove extra process call from vc-hg-registered
Date: Tue, 10 Nov 2020 17:45:28 +0200

Version: 28.1

On 09.11.2020 13:54, Tom Fitzhenry via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Prefer calling vc-state (rather than vc-hg-state) to benefit from the 
> caching in vc-state.
> 
> This same technique is used in vc-git.el, per commit "2018-06-28 "Remove 
> extra process call from vc-git-find-file-hook" 
> 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.

Makes sense, thanks! Pushed.

P.S. Next time please try to keep the line width within usual limits, I 
had to fix the following linter errors:

Line longer than 78 characters in commit message
Word longer than 140 characters in commit message
Commit aborted; please see the file CONTRIBUTE
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Dec 2020 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 194 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.