GNU bug report logs - #44534
[PATCH] Remove extra process call from vc-hg-registered

Previous Next

Package: emacs;

Reported by: Tom Fitzhenry <tomfitzhenry <at> google.com>

Date: Mon, 9 Nov 2020 15:26:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 44534-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Fitzhenry <tomfitzhenry <at> google.com>, 44534-done <at> debbugs.gnu.org
Subject: Re: bug#44534: [PATCH] Remove extra process call from vc-hg-registered
Date: Tue, 10 Nov 2020 17:45:28 +0200
Version: 28.1

On 09.11.2020 13:54, Tom Fitzhenry via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Prefer calling vc-state (rather than vc-hg-state) to benefit from the 
> caching in vc-state.
> 
> This same technique is used in vc-git.el, per commit "2018-06-28 "Remove 
> extra process call from vc-git-find-file-hook" 
> 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.

Makes sense, thanks! Pushed.

P.S. Next time please try to keep the line width within usual limits, I 
had to fix the following linter errors:

Line longer than 78 characters in commit message
Word longer than 140 characters in commit message
Commit aborted; please see the file CONTRIBUTE




This bug report was last modified 4 years and 195 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.