GNU bug report logs - #44495
[PATCH] gnu: Add emacs-monokai-theme.

Previous Next

Package: guix-patches;

Reported by: Noah Landis <noahlandis <at> posteo.net>

Date: Fri, 6 Nov 2020 23:40:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 44495-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Noah Landis <noahlandis <at> posteo.net>
Cc: 44495-done <at> debbugs.gnu.org
Subject: Re: [bug#44495] [PATCH] gnu: Add emacs-monokai-theme.
Date: Sat, 07 Nov 2020 10:47:35 +0100
Hello,

Noah Landis <noahlandis <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-monokai-theme.

Thank you!

I "fixed" the commit message, which should be:

    gnu: Add emacs-monokai-theme.

    * gnu/packages/emacs-xyz.scm (emacs-monokai-theme): New variable.

If you use Yasnippets, you can simply type "update" + TAB in an empty
commit buffer.

Also I suggest to insert new packages elsewhere than at the very end of
the "emacs-xyz.scm" file, as this location is prone to introduce merge
conflicts.

> +    (description
> +     "Monokai theme is a port of the popular TextMate Monokai theme for Emacs.
> +It uses built-in theming support available in Emacs 24 or later.")

I removed the last sentence, which is not useful in our context (Guix
provides Emacs 27).

Patch applied.

Regards,
-- 
Nicolas Goaziou




This bug report was last modified 4 years and 196 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.