GNU bug report logs - #44495
[PATCH] gnu: Add emacs-monokai-theme.

Previous Next

Package: guix-patches;

Reported by: Noah Landis <noahlandis <at> posteo.net>

Date: Fri, 6 Nov 2020 23:40:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44495 in the body.
You can then email your comments to 44495 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44495; Package guix-patches. (Fri, 06 Nov 2020 23:40:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Noah Landis <noahlandis <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 06 Nov 2020 23:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Landis <noahlandis <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-monokai-theme.
Date: Fri, 6 Nov 2020 16:39:04 -0700
From 5565ff611ba239b82141d0055bd71042be56419b Mon Sep 17 00:00:00 2001
From: Noah Landis <noahlandis <at> posteo.net>
Date: Fri, 6 Nov 2020 16:37:12 -0700
Subject: [PATCH] gnu: Add emacs-monokai-theme.

---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 47657c9ca0..3e231a93d1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25331,3 +25331,24 @@ service.")
 uncluttered design pattern to achieve optimal focus and readability for code
 syntax highlighting and UI components.")
     (license license:expat)))
+
+(define-public emacs-monokai-theme
+  (package
+    (name "emacs-monokai-theme")
+    (version "3.5.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/oneKelvinSmith/monokai-emacs")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0dy8c3349j7fmp8052hbgvk0b7ldlv5jqpg0paq1i0hlypivd30i"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/oneKelvinSmith/monokai-emacs")
+    (synopsis "High contrast color theme for Emacs")
+    (description
+     "Monokai theme is a port of the popular TextMate Monokai theme for Emacs.
+It uses built-in theming support available in Emacs 24 or later.")
+    (license license:gpl3+)))
-- 
2.29.2





Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sat, 07 Nov 2020 09:48:02 GMT) Full text and rfc822 format available.

Notification sent to Noah Landis <noahlandis <at> posteo.net>:
bug acknowledged by developer. (Sat, 07 Nov 2020 09:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 44495-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Noah Landis <noahlandis <at> posteo.net>
Cc: 44495-done <at> debbugs.gnu.org
Subject: Re: [bug#44495] [PATCH] gnu: Add emacs-monokai-theme.
Date: Sat, 07 Nov 2020 10:47:35 +0100
Hello,

Noah Landis <noahlandis <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-monokai-theme.

Thank you!

I "fixed" the commit message, which should be:

    gnu: Add emacs-monokai-theme.

    * gnu/packages/emacs-xyz.scm (emacs-monokai-theme): New variable.

If you use Yasnippets, you can simply type "update" + TAB in an empty
commit buffer.

Also I suggest to insert new packages elsewhere than at the very end of
the "emacs-xyz.scm" file, as this location is prone to introduce merge
conflicts.

> +    (description
> +     "Monokai theme is a port of the popular TextMate Monokai theme for Emacs.
> +It uses built-in theming support available in Emacs 24 or later.")

I removed the last sentence, which is not useful in our context (Guix
provides Emacs 27).

Patch applied.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 05 Dec 2020 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 196 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.