GNU bug report logs - #44321
[PATCH 0/6] Adding a (guix transformations) module

Previous Next

Full log

View this message in rfc822 format

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44321 <at> debbugs.gnu.org
Subject: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations).
Date: Sat, 31 Oct 2020 00:03:03 +0100

Hi Ludo,

Ludovic Courtès <ludo <at> gnu.org> writes:

> * guix/transformations.scm: New file.

The main comment regarding this patch is that file has to be added to
po/guix/POTFILES.in, or the translations will be lost.

I've seen that you've changed some code identifiers, here:
> -           (else  (tarball-base-name (file-sans-extension file-name)))))
> +           (_     (tarball-base-name (file-sans-extension file-name)))))

And there:
> -           (x
> +           (_

And these changes seem sensible as the match parameter is unused.

Other than the first comment, the patch LGTM.

Happy hacking,
Miguel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.