GNU bug report logs - #44322
28.0.50; Update biblatex entry types and fields in bibtex.el

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Thu, 29 Oct 2020 23:27:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44322 in the body.
You can then email your comments to 44322 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Thu, 29 Oct 2020 23:27:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Basil L. Contovounesios" <contovob <at> tcd.ie>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 29 Oct 2020 23:27:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Update biblatex entry types and fields in bibtex.el
Date: Thu, 29 Oct 2020 23:26:32 +0000
[Message part 1 (text/plain, inline)]
Tags: patch
thanks

Severity: minor
Tags: patch
X-Debbugs-Cc: Roland Winkler <winkler <at> gnu.org>

I went through the latest biblatex manual on my system
(v3.15 of 2020-08-19) and updated bibtex-biblatex-entry-alist
and bibtex-biblatex-field-alist accordingly.

The dataset and software entry types were missing, as were the
eventtitleaddon, issuetitleaddon, journaltitleaddon, shorthand, and
shorthandintro fields.  Several existing entry types were missing an
optional eid field, or had other deviations from the biblatex
documentation.

While there, I also fixed the abbreviation of PhD, which is normally
spelt either Ph.D. (two full stops) or PhD (no full stops).

How's the attached patch?

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2020-10-29 built on thunk
Repository revision: ada9b7c9cecdbc2dd6cbd08553d8f83cb80f793a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid

[0001-Sync-biblatex-entries-and-fields-with-v3.15.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Thu, 29 Oct 2020 23:50:02 GMT) Full text and rfc822 format available.

Message #8 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 44322 <at> debbugs.gnu.org
Cc: Roland Winkler <winkler <at> gnu.org>
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Thu, 29 Oct 2020 23:49:35 +0000
severity 44322 minor
quit

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Tags: patch
> thanks

Ugh, I fixed this bug in submit-emacs-patch on master[1].  I wanted to
try it out, saw that it unconditionally shortcircuits custom
pseudo-headers, switched to the usual report-emacs-bug, but was still
bitten by the global add-hook in submit-emacs-patch.

[1]: Modify only local send hook in submit-emacs-patch
d7a2d7250d 2020-10-29 23:33:29 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7a2d7250d74ab91dc7fb21325b39ea801b0796b

Another recent bug/annoyance I hit in either report-emacs-bug or
submit-emacs-patch is that I was prompted for how to send the email via
sendmail-query-user-about-smtp, which doesn't usually happen when
sending normal emails.  It then also asked me if I wanted to save the
resulting send-mail-function to my custom-file.  I guess I'll look into
this more next time I email bug-gnu-emacs.

> Severity: minor
> Tags: patch
> X-Debbugs-Cc: Roland Winkler <winkler <at> gnu.org>

CCed now.

-- 
Basil




Severity set to 'minor' from 'normal' Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Thu, 29 Oct 2020 23:50:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Fri, 30 Oct 2020 12:35:01 GMT) Full text and rfc822 format available.

Message #13 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 44322 <at> debbugs.gnu.org, Roland Winkler <winkler <at> gnu.org>
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Fri, 30 Oct 2020 13:34:40 +0100
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Another recent bug/annoyance I hit in either report-emacs-bug or
> submit-emacs-patch is that I was prompted for how to send the email via
> sendmail-query-user-about-smtp, which doesn't usually happen when
> sending normal emails.  It then also asked me if I wanted to save the
> resulting send-mail-function to my custom-file.  I guess I'll look into
> this more next time I email bug-gnu-emacs.

Hm, odd.  That doesn't happen when I use the function...  Do you have
message-send-mail-function customised but not send-mail-function or some
other combination of settings here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Fri, 30 Oct 2020 13:19:02 GMT) Full text and rfc822 format available.

Message #16 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44322 <at> debbugs.gnu.org, Roland Winkler <winkler <at> gnu.org>
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Fri, 30 Oct 2020 13:18:04 +0000
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Another recent bug/annoyance I hit in either report-emacs-bug or
>> submit-emacs-patch is that I was prompted for how to send the email via
>> sendmail-query-user-about-smtp, which doesn't usually happen when
>> sending normal emails.  It then also asked me if I wanted to save the
>> resulting send-mail-function to my custom-file.  I guess I'll look into
>> this more next time I email bug-gnu-emacs.
>
> Hm, odd.  That doesn't happen when I use the function...  Do you have
> message-send-mail-function customised but not send-mail-function or some
> other combination of settings here?

My relevant settings are:

  (setq-default
   message-confirm-send t
   message-send-mail-function #'message-send-mail-with-sendmail
   message-sendmail-envelope-from 'header
   sendmail-program "msmtp")

Do I now need to also set send-mail-function to sendmail-send-it?

[I'm guessing the current behaviour is due to the new setq's in
report-emacs-bug-hook.]

Thanks,

-- 
Basil




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Sun, 01 Nov 2020 12:02:02 GMT) Full text and rfc822 format available.

Message #19 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 44322 <at> debbugs.gnu.org, Roland Winkler <winkler <at> gnu.org>
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Sun, 01 Nov 2020 13:00:58 +0100
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> My relevant settings are:
>
>   (setq-default
>    message-confirm-send t
>    message-send-mail-function #'message-send-mail-with-sendmail
>    message-sendmail-envelope-from 'header
>    sendmail-program "msmtp")
>
> Do I now need to also set send-mail-function to sendmail-send-it?

Yes, the Message variables inherit from it, so setting the Message
variables directly should no longer be necessary.

> [I'm guessing the current behaviour is due to the new setq's in
> report-emacs-bug-hook.]

Yes and no -- it's more fallout from the sendmail/message integration
work from a few years back, compounded by more DWIM stuff that's been
added later.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Sun, 01 Nov 2020 15:08:01 GMT) Full text and rfc822 format available.

Message #22 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44322 <at> debbugs.gnu.org
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Sun, 01 Nov 2020 15:07:28 +0000
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> My relevant settings are:
>>
>>   (setq-default
>>    message-confirm-send t
>>    message-send-mail-function #'message-send-mail-with-sendmail
>>    message-sendmail-envelope-from 'header
>>    sendmail-program "msmtp")
>>
>> Do I now need to also set send-mail-function to sendmail-send-it?
>
> Yes, the Message variables inherit from it, so setting the Message
> variables directly should no longer be necessary.

Okay, I can set send-mail-function to sendmail-send-it and then
message-default-send-mail-function will automatically resolve to
message-send-mail-with-sendmail.

But what value should I set debbugs-gnu-send-mail-function to?
Nil (meaning send-mail-function), or message-send-mail-with-sendmail?
Does it make a difference?

Thanks,

-- 
Basil




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Mon, 02 Nov 2020 15:02:01 GMT) Full text and rfc822 format available.

Message #25 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 44322 <at> debbugs.gnu.org
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Mon, 02 Nov 2020 16:00:42 +0100
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> But what value should I set debbugs-gnu-send-mail-function to?
> Nil (meaning send-mail-function), or message-send-mail-with-sendmail?
> Does it make a difference?

I don't think it makes a difference -- just leave it as nil, I think?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Wed, 04 Nov 2020 21:55:01 GMT) Full text and rfc822 format available.

Message #28 received at 44322 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44322 <at> debbugs.gnu.org
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Wed, 04 Nov 2020 21:53:57 +0000
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> But what value should I set debbugs-gnu-send-mail-function to?
>> Nil (meaning send-mail-function), or message-send-mail-with-sendmail?
>> Does it make a difference?
>
> I don't think it makes a difference -- just leave it as nil, I think?

Turns out it was a silly question - message-send-mail-with-sendmail will
obviously heed message.el settings that send-mail-function doesn't know
about, such as message-sendmail-envelope-from.

-- 
Basil




Added tag(s) fixed. Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Thu, 05 Nov 2020 11:53:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 44322 <at> debbugs.gnu.org and "Basil L. Contovounesios" <contovob <at> tcd.ie> Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Thu, 05 Nov 2020 11:53:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44322; Package emacs. (Thu, 05 Nov 2020 11:53:03 GMT) Full text and rfc822 format available.

Message #35 received at 44322-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 44322-done <at> debbugs.gnu.org
Subject: Re: bug#44322: 28.0.50; Update biblatex entry types and fields in
 bibtex.el
Date: Thu, 05 Nov 2020 11:52:47 +0000
tags 44322 fixed
close 44322 28.1
quit

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> How's the attached patch?

Now pushed to master, so I'm closing this report.

Sync biblatex entries and fields with v3.15
771046f5d8 2020-11-05 11:30:34 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=771046f5d888c703c875d8629fdf227429a36d3d

-- 
Basil




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 03 Dec 2020 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.