GNU bug report logs - #44321
[PATCH 0/6] Adding a (guix transformations) module

Previous Next

Full log

Message #35 received at 44321 <at> debbugs.gnu.org (full text, mbox):

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 44321 <at> debbugs.gnu.org
Subject: Re: [bug#44321] [PATCH 5/6] transformations: Raise
 '&formatted-message' exceptions instead of 'leave'.
Date: Fri, 30 Oct 2020 23:39:03 +0100

[Message part 1 (text/plain, inline)]

Hi simon and Ludo,

zimoun <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> On Fri, 30 Oct 2020 at 00:09, Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> (transform-package-toolchain): Use 'raise' and 'formatted-message'
>> instead of 'leave'.
>
> Naive question: what is the difference?  Other said why?  And so why not
> replaces ’leave’ here and there by ’raise’+’formatted-message’?

Probably Ludo can explain better, but the main difference I see is that
leave (guix diagnostics) calls exit, so the client code now can handle
these errors and it isn't forced to exit.

The patch LGTM.  Just one extra comment, this changes some format
strings, so we shouldn't forget to send the latest pot files to TP as
soon as we generate the branch for the release.

Happy hacking!
Miguel

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.