GNU bug report logs - #44321
[PATCH 0/6] Adding a (guix transformations) module

Previous Next

Full log

View this message in rfc822 format

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44321 <at> debbugs.gnu.org
Subject: [bug#44321] [PATCH 3/6] guix build: 'options->transformation' no longer takes a 'store' parameter.
Date: Fri, 30 Oct 2020 23:27:29 +0100

[Message part 1 (text/plain, inline)]

Hi Ludo,

I just have one comment here:

Ludovic Courtès <ludo <at> gnu.org> writes:
> ("options->transformation, with-source")
> ("options->transformation, with-source, replacement")
> ("options->transformation, with-source, with version")
> ("options->transformation, with-source, PKG=URI"): Use 'lower-object' to
> compute the store file name of the source.
[...]
> @@ -64,12 +66,9 @@
>    (let* ((p (dummy-package "guix.scm" (replacement coreutils)))
>           (s (search-path %load-path "guix.scm"))
>           (t (options->transformation `((with-source . ,s)))))
> -    (with-store store
> -      (let ((new (t store p)))
> -        (and (not (eq? new p))
> -             (string=? (package-source new)
> -                       (add-to-store store "guix.scm" #t "sha256" s))
> -             (not (package-replacement new)))))))
> +    (let ((new (t p)))
> +      (and (not (eq? new p))
> +           (not (package-replacement new))))))
>  
>  (test-assert "options->transformation, with-source, with version"
>    ;; Our pseudo-package is called 'guix.scm' so the 'guix.scm-2.0' source

It's the only one that doesn't follow the same pattern as others, where
the change look quite similar: instead of (t store p) -> (t p) (source
(run-...)), also specified in the message.

If removing that comparison is intended, I think the commit message
should be changed.  Otherwise it LGTM.

Happy hacking!
Miguel

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.