GNU bug report logs - #44317
[PATCH] cperl-mode: Make timeout tests more robust

Previous Next

Package: emacs;

Reported by: haj <at> posteo.de (Harald Jörg)

Date: Thu, 29 Oct 2020 21:10:01 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Harald Jörg <haj <at> posteo.de>, 44317 <at> debbugs.gnu.org
Subject: bug#44317: [PATCH] cperl-mode: Make timeout tests more robust
Date: Thu, 29 Oct 2020 14:49:22 -0700
close 44317 28.1
thanks

haj <at> posteo.de (Harald Jörg) writes:

> One of the tests in cperl-mode-tests.el starts an external Emacs process
> under timeout to check for an endless loop.  It turns out that the
> timeout of 1 sec is rather short for slower machines.  Thanks to recent
> ERT which now reports the run time in batch tests, I saw that it takes
> about 0.7 seconds on my machine, so I increased the timeout to 2
> seconds.
>
> I also flagged the test as "expensive" and skip it under older Emacs
> versions (I run tests for Emacs version 26.1 and above).

Thanks, makes sense.  Pushed to master as commit 96e371b44a.




This bug report was last modified 4 years and 298 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.