GNU bug report logs - #44317
[PATCH] cperl-mode: Make timeout tests more robust

Previous Next

Package: emacs;

Reported by: haj <at> posteo.de (Harald Jörg)

Date: Thu, 29 Oct 2020 21:10:01 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44317 in the body.
You can then email your comments to 44317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44317; Package emacs. (Thu, 29 Oct 2020 21:10:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to haj <at> posteo.de (Harald Jörg):
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 29 Oct 2020 21:10:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] cperl-mode: Make timeout tests more robust
Date: Thu, 29 Oct 2020 22:09:29 +0100

[Message part 1 (text/plain, inline)]
One of the tests in cperl-mode-tests.el starts an external Emacs process
under timeout to check for an endless loop.  It turns out that the
timeout of 1 sec is rather short for slower machines.  Thanks to recent
ERT which now reports the run time in batch tests, I saw that it takes
about 0.7 seconds on my machine, so I increased the timeout to 2
seconds.

I also flagged the test as "expensive" and skip it under older Emacs
versions (I run tests for Emacs version 26.1 and above).

[0001-cperl-mode-Make-timeout-test-more-robust.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44317; Package emacs. (Thu, 29 Oct 2020 21:50:02 GMT) Full text and rfc822 format available.

Message #8 received at 44317 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Harald Jörg <haj <at> posteo.de>, 44317 <at> debbugs.gnu.org
Subject: Re: bug#44317: [PATCH] cperl-mode: Make timeout tests more robust
Date: Thu, 29 Oct 2020 14:49:22 -0700

close 44317 28.1
thanks

haj <at> posteo.de (Harald Jörg) writes:

> One of the tests in cperl-mode-tests.el starts an external Emacs process
> under timeout to check for an endless loop.  It turns out that the
> timeout of 1 sec is rather short for slower machines.  Thanks to recent
> ERT which now reports the run time in batch tests, I saw that it takes
> about 0.7 seconds on my machine, so I increased the timeout to 2
> seconds.
>
> I also flagged the test as "expensive" and skip it under older Emacs
> versions (I run tests for Emacs version 26.1 and above).

Thanks, makes sense.  Pushed to master as commit 96e371b44a.
bug marked as fixed in version 28.1, send any further explanations to 44317 <at> debbugs.gnu.org and haj <at> posteo.de (Harald Jörg) Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 29 Oct 2020 21:50:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 27 Nov 2020 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 298 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.