GNU bug report logs - #44260
[PATCH 0/1] knot-resolver: Silence warning re: deprecated option

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44260 in the body.
You can then email your comments to 44260 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: guix-patches <at> gnu.org
Cc: simon <at> simonsouth.net
Subject: [PATCH 0/1] knot-resolver: Silence warning re: deprecated option
Date: Tue, 27 Oct 2020 14:21:39 -0400

This small patch silences this warning from Knot Resolver when it starts:

   deprecation WARNING: use --noninteractive instead of --forks=1

With version 5.0.0 the "-f" option was deprecated[0] in favour of "-n" as a
means of starting the daemon as a non-interactive process.

The patch updates Guix's service definition to match, without any functional
change to the service.

[0] https://gitlab.nic.cz/knot/knot-resolver/issues/529

--
Simon South
simon <at> simonsouth.net


Simon South (1):
  services: knot-resolver: Replace deprecated command-line option.

 gnu/services/dns.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.28.0

Message #8 received at 44260 <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: 44260 <at> debbugs.gnu.org
Cc: simon <at> simonsouth.net
Subject: [PATCH 1/1] services: knot-resolver: Replace deprecated command-line
 option.
Date: Tue, 27 Oct 2020 14:23:19 -0400

This silences a warning from the service at startup.

* gnu/services/dns.scm (knot-resolver-shepherd-services)[start]: Use the "-n"
command-line option to kresd in place of the deprecated "-f 1".
---
 gnu/services/dns.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm
index 572880561c..b339eb0619 100644
--- a/gnu/services/dns.scm
+++ b/gnu/services/dns.scm
@@ -700,7 +700,7 @@ cache.size = 100 * MB
        (documentation "Run the Knot Resolver daemon.")
        (start #~(make-forkexec-constructor
                  '(#$(file-append package "/sbin/kresd")
-                   "-c" #$kresd-config-file "-f" "1"
+                   "-c" #$kresd-config-file "-n"
                    "/var/cache/knot-resolver")))
        (stop #~(make-kill-destructor)))
       (shepherd-service
-- 
2.28.0

Message #13 received at 44260-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Simon South <simon <at> simonsouth.net>
Cc: 44260-done <at> debbugs.gnu.org
Subject: Re: [bug#44260] [PATCH 1/1] services: knot-resolver: Replace
 deprecated command-line option.
Date: Tue, 27 Oct 2020 18:43:10 -0400

On Tue, Oct 27, 2020 at 02:23:19PM -0400, Simon South wrote:
> This silences a warning from the service at startup.
> 
> * gnu/services/dns.scm (knot-resolver-shepherd-services)[start]: Use the "-n"
> command-line option to kresd in place of the deprecated "-f 1".

Thanks! Pushed as 5ede2595260d74e2990a8f004298ecf23ea66206

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.