GNU bug report logs - #44259
Most mml-sec.el tests are failing on macOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44259 in the body.
You can then email your comments to 44259 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Most mml-sec.el tests are failing on macOS
Date: Tue, 27 Oct 2020 19:16:57 +0100

Most mml-sec.el tests are failing on macOS.  Here is my analysis.

In mml-sec-tests.el, the cleanup in mml-sec-test--kill-gpg-agent
depends on the 'args key in the alist returned by process-attributes.
But evaluating following on macOS gives nil:

   (assq 'args (process-attributes (emacs-pid)))

Support for `args' seems to be not implemented on macOS.  See
src/sysdep.c, function system_process_attributes.

This was previously discussed in Bug#16579, where support for
process-attributes was first added. It seems like the API for all this
is not documented, so it's tricky to add.

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=16579#5

So I guess we either should make the tests not depend on 'args, or
figure out how to implement the above support for macOS.

Message #8 received at 44259 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 44259 <at> debbugs.gnu.org
Subject: Re: bug#44259: Most mml-sec.el tests are failing on macOS
Date: Tue, 27 Oct 2020 21:08:40 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> So I guess we either should make the tests not depend on 'args, or
> figure out how to implement the above support for macOS.

Or we could just disable these tests on Macos...  I'm not sure these
test bring us that much of value.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 44259 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44259 <at> debbugs.gnu.org
Subject: Re: bug#44259: Most mml-sec.el tests are failing on macOS
Date: Tue, 27 Oct 2020 21:41:15 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> So I guess we either should make the tests not depend on 'args, or
>> figure out how to implement the above support for macOS.
>
> Or we could just disable these tests on Macos...  I'm not sure these
> test bring us that much of value.

Works for me.

Message #14 received at 44259 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 44259 <at> debbugs.gnu.org
Subject: Re: bug#44259: Most mml-sec.el tests are failing on macOS
Date: Wed, 28 Oct 2020 11:55:07 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

>> Or we could just disable these tests on Macos...  I'm not sure these
>> test bring us that much of value.
>
> Works for me.

Done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.