GNU bug report logs - #44215
[PATCH 0/4] Some smaller KDE changes.

Previous Next

Full log

Message #38 received at 44215 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 44215 <at> debbugs.gnu.org
Subject: Re: [bug#44215] [PATCH 4/4] gnu: kscreenlocker: Use qt-build-system.
Date: Tue, 27 Oct 2020 10:57:58 +0200

[Message part 1 (text/plain, inline)]

How about gating the tests behind the tests? flag?

On Sun, Oct 25, 2020 at 10:09:22PM +0100, Hartmut Goebel wrote:
> * gnu/packages/kde-plasma.scm (kscreeenlocker)[buoild-system]: Change to
>   qt-build-system. [arguments]{phases}<check> Remove unsued code; Actually
>   disable running the tests.
> ---
>  gnu/packages/kde-plasma.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
> index ce6abb3a65..6e6213161c 100644
> --- a/gnu/packages/kde-plasma.scm
> +++ b/gnu/packages/kde-plasma.scm
> @@ -70,7 +70,7 @@ manager which re-parents a Client window to a window decoration frame.")
>                (sha256
>                 (base32
>                  "1lhq9rxafbbxwpwzq8m25xi9hgcdfdfwl8hafqhygzp14z89q9ml"))))
> -    (build-system cmake-build-system)
> +    (build-system qt-build-system)
>      (arguments
>       `(#:phases

        `(#:tests? #f
          #:phases

>         (modify-phases %standard-phases
> @@ -84,12 +84,11 @@ manager which re-parents a Client window to a window decoration frame.")
>           ;; Tests use the installed library and require a DBus session.
>           (add-after 'install 'check
>             (lambda _
> -             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
> -             (invoke "dbus-launch" "ctest" "."))))))
> +             ;;(invoke "dbus-launch" "ctest" ".") ;; FIXME: try to make this pass
> +             #t)))))

(lambda* (#:key tests? #:allow-other-keys)
  (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
  (if tests?
    (invoke "dbus-launch" "ctest" ".")
    #t))


>      (native-inputs
>       `(("extra-cmake-modules" ,extra-cmake-modules)
>         ("pkg-config" ,pkg-config)
> -
>         ;; For tests.
>         ("dbus" ,dbus)
>         ("xorg-server" ,xorg-server-for-tests)))
> -- 
> 2.21.3
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.