GNU bug report logs - #44214
28.0.50; css-mode: no completion in declaration with newline after

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44214 in the body.
You can then email your comments to 44214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; css-mode: no completion in declaration with newline after
Date: Sun, 25 Oct 2020 22:41:35 +0200

X-Debbugs-CC: Simen Heggestøyl <simenheg <at> gmail.com>

1. Create new buffer (or switch to scratch), then M-x css-mode.
2. Replace the contents with the following:

div {
  transform:
    rota

3. Move the point to the end of 'rota' and type C-M-i.

4. See no completions.

If there is no newline after the colon, before the attribute value,
C-M-i does perform completion.

Originally reported in 
https://github.com/company-mode/company-mode/issues/1029

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 
3.24.20, cairo version 1.16.0)
 of 2020-10-11 built on potemkin
Repository revision: c66165b5c08e12c5dcf494fea42e61df693b80b9
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Ubuntu 20.04.1 LTS

Message #8 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44214 <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Mon, 26 Oct 2020 10:24:30 +0100

This seems sufficient to me. Would you like to test it out?

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 0d1eeed561..748a561bab 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -1357,7 +1357,9 @@ css--property-values
 (defun css--complete-property-value ()
   "Complete property value at point."
   (let ((property (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*"
-                                     (line-beginning-position) t)
+                                     (or (ppss-innermost-start (syntax-ppss))
+                                         (point-min))
+                                     t)
                        (member (match-string-no-properties 1)
                                css-property-ids))))
     (when property

Message #11 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: 44214 <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Mon, 26 Oct 2020 23:57:41 +0200

On 26.10.2020 11:24, Simen Heggestøyl wrote:
> This seems sufficient to me. Would you like to test it out?

Seems to work, yeah!

Thank you.

BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at 
all reachable?

Message #16 received at 44214-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44214-done <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Tue, 27 Oct 2020 15:21:46 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 26.10.2020 11:24, Simen Heggestøyl wrote:
>> This seems sufficient to me. Would you like to test it out?
>
> Seems to work, yeah!

Nice, I've pushed the fix.

> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at
> all reachable?

Yes, when called from top level.

Message #19 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 44214 <at> debbugs.gnu.org, simenheg <at> runbox.com
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Tue, 27 Oct 2020 23:06:09 +0200

On 27.10.2020 16:21, Simen Heggestøyl wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> On 26.10.2020 11:24, Simen Heggestøyl wrote:
>>> This seems sufficient to me. Would you like to test it out?
>>
>> Seems to work, yeah!
> 
> Nice, I've pushed the fix.

Thanks! Seems to work.

>> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at
>> all reachable?
> 
> Yes, when called from top level.

Should the search ever succeed in this case, though? I would suggest to 
use (point) instead of (point-min) to auto-fail:

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 748a561bab..747657b1ed 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -1358,7 +1358,7 @@ css--complete-property-value
   "Complete property value at point."
   (let ((property (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*"
                                      (or (ppss-innermost-start 
(syntax-ppss))
-                                         (point-min))
+                                         (point))
                                      t)
                        (member (match-string-no-properties 1)
                                css-property-ids))))


Otherwise, we both do the costly-ish search from the bob, and even risk 
it succeed in rare cases where the CSS in the previous rule is 
incomplete (or the semicolon is omitted), e.g.:

a {
  animation-delay: inherit
}

cal|

Message #22 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44214 <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Tue, 27 Oct 2020 22:11:33 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

>>> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at
>>> all reachable?
>> Yes, when called from top level.
>
> Should the search ever succeed in this case, though? I would suggest
> to use (point) instead of (point-min) to auto-fail:
>
> [...]
>
> Otherwise, we both do the costly-ish search from the bob, and even
> risk it succeed in rare cases where the CSS in the previous rule is 
> incomplete (or the semicolon is omitted)

Good point, I didn't think about that.

Your proposed fixed looks good to me.

Message #25 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: 44214 <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Wed, 28 Oct 2020 03:44:02 +0200

On 27.10.2020 23:11, Simen Heggestøyl wrote:
> Good point, I didn't think about that.
> 
> Your proposed fixed looks good to me.

Thanks, now pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.