GNU bug report logs - #44214
28.0.50; css-mode: no completion in declaration with newline after

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Sun, 25 Oct 2020 20:42:01 UTC

Severity: normal

Found in version 28.0.50

Done: Simen Heggestøyl <simenheg <at> runbox.com>

Bug is archived. No further changes may be made.

Full log


Message #22 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 44214 <at> debbugs.gnu.org
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Tue, 27 Oct 2020 22:11:33 +0100
Dmitry Gutov <dgutov <at> yandex.ru> writes:

>>> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at
>>> all reachable?
>> Yes, when called from top level.
>
> Should the search ever succeed in this case, though? I would suggest
> to use (point) instead of (point-min) to auto-fail:
>
> [...]
>
> Otherwise, we both do the costly-ish search from the bob, and even
> risk it succeed in rare cases where the CSS in the previous rule is 
> incomplete (or the semicolon is omitted)

Good point, I didn't think about that.

Your proposed fixed looks good to me.




This bug report was last modified 4 years and 267 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.