GNU bug report logs - #44214
28.0.50; css-mode: no completion in declaration with newline after

Previous Next

Full log

Message #19 received at 44214 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 44214 <at> debbugs.gnu.org, simenheg <at> runbox.com
Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with
 newline after
Date: Tue, 27 Oct 2020 23:06:09 +0200

On 27.10.2020 16:21, Simen Heggestøyl wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> On 26.10.2020 11:24, Simen Heggestøyl wrote:
>>> This seems sufficient to me. Would you like to test it out?
>>
>> Seems to work, yeah!
> 
> Nice, I've pushed the fix.

Thanks! Seems to work.

>> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at
>> all reachable?
> 
> Yes, when called from top level.

Should the search ever succeed in this case, though? I would suggest to 
use (point) instead of (point-min) to auto-fail:

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 748a561bab..747657b1ed 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -1358,7 +1358,7 @@ css--complete-property-value
   "Complete property value at point."
   (let ((property (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*"
                                      (or (ppss-innermost-start 
(syntax-ppss))
-                                         (point-min))
+                                         (point))
                                      t)
                        (member (match-string-no-properties 1)
                                css-property-ids))))


Otherwise, we both do the costly-ish search from the bob, and even risk 
it succeed in rare cases where the CSS in the previous rule is 
incomplete (or the semicolon is omitted), e.g.:

a {
  animation-delay: inherit
}

cal|

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.