GNU bug report logs - #44001
vc-print-log-setup-buttons leaves point at eob

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44001 in the body.
You can then email your comments to 44001 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thien-Thi Nguyen <ttn <at> gnuvola.org>
To: bug-gnu-emacs <at> gnu.org
Subject: vc-print-log-setup-buttons leaves point at eob
Date: Wed, 14 Oct 2020 19:55:25 -0400

[Message part 1 (text/plain, inline)]

I have the following in my ~/.emacs flow:

;; 2020-02-01
;;
;; As of Emacs 26 (or thereabouts), ‘C-x v l’ for files w/
;; "fewer" commits, leaves point at the end of the buffer,
;; whereas it used to leave it at the beginning, or rather on
;; the "selected" commit entry, which typically was the first --
;; same result after all.
;;
;; The culprit seems to be the buttons for extending the commit
;; range, drawn at the end of the buffer by
;; ‘vc-print-log-setup-buttons’.  This advice fixes things for
;; now.  The true fix will be to upstream this, either directly
;; into the function itself, or into its caller.  Probably
;; better to do it in the caller.
;;
;; FIXME: Upstream the fix!
;;
(advice-add 'vc-print-log-setup-buttons :around
            (lambda (orig-fun &rest args)
              "Do ‘save-excursion’ around the original function."
              (save-excursion
                (apply orig-fun args))))

I know advice is not the right way to do it, but am writing to
ask if this approach is okay.  (If so, i can work up a patch.)

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)               ; (2020) Software Libero
   (pcase (context query)               ;       = Dissenso Etico
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 44001 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Thien-Thi Nguyen <ttn <at> gnuvola.org>
Cc: 44001 <at> debbugs.gnu.org
Subject: Re: bug#44001: vc-print-log-setup-buttons leaves point at eob
Date: Thu, 15 Oct 2020 09:52:40 +0300

Thien-Thi Nguyen <ttn <at> gnuvola.org> writes:

> I have the following in my ~/.emacs flow:
>
> ;; 2020-02-01
> ;;
> ;; As of Emacs 26 (or thereabouts), ‘C-x v l’ for files w/
> ;; "fewer" commits, leaves point at the end of the buffer,
> ;; whereas it used to leave it at the beginning, or rather on

Can you please provide receipt to reproduce this?  For me, on Emacs 28:

1. emacs -Q
2. C-x C-f <file-under-git-repo>
3. C-x v l

The point is at the top log entry.

Message #11 received at 44001 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Thien-Thi Nguyen <ttn <at> gnuvola.org>
Cc: 44001 <at> debbugs.gnu.org
Subject: Re: bug#44001: vc-print-log-setup-buttons leaves point at eob
Date: Thu, 15 Oct 2020 09:57:49 +0300

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Thien-Thi Nguyen <ttn <at> gnuvola.org> writes:
>
>> I have the following in my ~/.emacs flow:
>>
>> ;; 2020-02-01
>> ;;
>> ;; As of Emacs 26 (or thereabouts), ‘C-x v l’ for files w/
>> ;; "fewer" commits, leaves point at the end of the buffer,
>> ;; whereas it used to leave it at the beginning, or rather on
>
> Can you please provide receipt to reproduce this?  For me, on Emacs 28:
>
> 1. emacs -Q
> 2. C-x C-f <file-under-git-repo>
> 3. C-x v l
>
> The point is at the top log entry.

Looks like this was fixed in bug#31764:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31764

Message #14 received at 44001 <at> debbugs.gnu.org (full text, mbox):

From: Thien-Thi Nguyen <ttn <at> gnuvola.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: Thien-Thi Nguyen <ttn <at> gnuvola.org>, 44001 <at> debbugs.gnu.org
Subject: Re: bug#44001: vc-print-log-setup-buttons leaves point at eob
Date: Thu, 15 Oct 2020 04:04:46 -0400

[Message part 1 (text/plain, inline)]

() Andrii Kolomoiets <andreyk.mad <at> gmail.com>
() Thu, 15 Oct 2020 09:57:49 +0300

   Looks like this was fixed in bug#31764:
   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31764

Indeed, and w/ the same approach i stumbled upon.
Thanks!  I suppose we can close this bug, then.

BTW, for future reference, how did you find this
previous bug report?

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)               ; (2020) Software Libero
   (pcase (context query)               ;       = Dissenso Etico
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 44001 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Thien-Thi Nguyen <ttn <at> gnuvola.org>
Cc: 44001 <at> debbugs.gnu.org, Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#44001: vc-print-log-setup-buttons leaves point at eob
Date: Thu, 15 Oct 2020 10:21:36 +0200

>>>>> On Thu, 15 Oct 2020 04:04:46 -0400, Thien-Thi Nguyen <ttn <at> gnuvola.org> said:

    Thien-Thi> () Andrii Kolomoiets <andreyk.mad <at> gmail.com>
    Thien-Thi> () Thu, 15 Oct 2020 09:57:49 +0300

    Thien-Thi>    Looks like this was fixed in bug#31764:
    Thien-Thi>    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31764

    Thien-Thi> Indeed, and w/ the same approach i stumbled upon.
    Thien-Thi> Thanks!  I suppose we can close this bug, then.

    Thien-Thi> BTW, for future reference, how did you find this
    Thien-Thi> previous bug report?

I donʼt know about Andrii, but 'git log --grep
vc-print-log-setup-buttons' will do it.

Robert
-- 

Message #20 received at 44001 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Thien-Thi Nguyen <ttn <at> gnuvola.org>
Cc: 44001 <at> debbugs.gnu.org
Subject: Re: bug#44001: vc-print-log-setup-buttons leaves point at eob
Date: Thu, 15 Oct 2020 11:23:36 +0300

Thien-Thi Nguyen <ttn <at> gnuvola.org> writes:

> () Andrii Kolomoiets <andreyk.mad <at> gmail.com>
> () Thu, 15 Oct 2020 09:57:49 +0300
>
>    Looks like this was fixed in bug#31764:
>    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31764
>
> Indeed, and w/ the same approach i stumbled upon.
> Thanks!  I suppose we can close this bug, then.
>
> BTW, for future reference, how did you find this
> previous bug report?

Found call to 'vc-print-log-setup-buttons' in 'vc-print-log-internal' in
vc.el, noticed it's already under 'save-excursion'.
Then 'vc-annotate' (C-x v g) and then
'vc-annotate-show-log-revision-at-line' (l).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.