GNU bug report logs - #43754
[PATCH] configure help message of --with-json

Previous Next

Package: emacs;

Reported by: Shohei Yoshida <syohex <at> gmail.com>

Date: Fri, 2 Oct 2020 00:49:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: bug#43754: [PATCH] configure help message of --with-json
Date: Sat, 03 Oct 2020 20:59:19 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: syohex <at> gmail.com,  43754 <at> debbugs.gnu.org
> Date: Sat, 03 Oct 2020 19:49:33 +0200
> 
> Oh, hey, whaddayaknow, it was a patch I applied a couple months ago:
> 
> commit 43091e6c5069797ba17d2c7429e0122d3a5337d9
> Author:     Noam Postavsky <npostavs <at> gmail.com>
> AuthorDate: Fri Aug 14 19:31:16 2020 +0200
> Commit:     Lars Ingebrigtsen <larsi <at> gnus.org>
> CommitDate: Fri Aug 14 19:31:16 2020 +0200
> 
>     Make configure say so if we have "--with-json" but no jansson support
>     
>     * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro.  Use it to
>     define the --with-json option.  Add with_json and HAVE_JSON to the
>     'MISSING' checks (bug#39953).
> 
> bug#39953 has the rationale behind the change.

What I said there notwithstanding, it looks like --with-json is the
odd one out nowadays, as we handle all the other optional libraries
differently.  So it seems to me that we should switch to DEFAULT_ON
for this library.

Obviously, it is not a catastrophe to leave it as it is now...




This bug report was last modified 4 years and 226 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.