GNU bug report logs - #43754
[PATCH] configure help message of --with-json

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43754 in the body.
You can then email your comments to 43754 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shohei Yoshida <syohex <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] configure help message of --with-json
Date: Fri, 2 Oct 2020 09:48:08 +0900

[Message part 1 (text/plain, inline)]

version: git master(40b81f847f12cf141467a02858d1ac09589cea2f)

configure --help says

```
./configure --help
...
--with-json             don't compile with native JSON support
```

This is the opposite meaning. --with-json means "compile with native
JSON support"

Regards

-- 
Shohei YOSHIDA(syohex <at> gmail.com)

[0001-Fix-with-json-message.patch (text/x-patch, attachment)]

Message #8 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Shohei Yoshida <syohex <at> gmail.com>
Cc: 43754 <at> debbugs.gnu.org
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Fri, 02 Oct 2020 03:14:56 +0200

Shohei Yoshida <syohex <at> gmail.com> writes:

> This is the opposite meaning. --with-json means "compile with native
> JSON support"

Thanks for the patch; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: 황병희 <soyeomul <at> doraji.xyz>
To: 43754 <at> debbugs.gnu.org
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Fri, 02 Oct 2020 11:54:57 +0900

[just quick comment]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Shohei Yoshida <syohex <at> gmail.com> writes:
>
>> This is the opposite meaning. --with-json means "compile with native
>> JSON support"
>
> Thanks for the patch; applied to Emacs 28.

Personally i did mark this PR [43754] as *IMPORTANT*. Because currently
i use JSON things very useful in _real_ work/day-job.

Sincerely, JSON fan Byung-Hee

-- 
^고맙습니다 _地平天成_ 감사합니다_^))//

Message #18 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Fri, 02 Oct 2020 09:47:36 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Fri, 02 Oct 2020 03:14:56 +0200
> Cc: 43754 <at> debbugs.gnu.org
> 
> Shohei Yoshida <syohex <at> gmail.com> writes:
> 
> > This is the opposite meaning. --with-json means "compile with native
> > JSON support"
> 
> Thanks for the patch; applied to Emacs 28.

Any reason why we use OPTION_DEFAULT_IFAVAILABLE for json, and not
OPTION_DEFAULT_ON?  How is it different from libpng or liblcms2 or
libgnutls?

Message #21 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Fri, 02 Oct 2020 16:28:38 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Any reason why we use OPTION_DEFAULT_IFAVAILABLE for json, and not
> OPTION_DEFAULT_ON?  How is it different from libpng or liblcms2 or
> libgnutls?

I wonder whether it's because of this:

case $with_gnutls,$HAVE_GNUTLS in
  no,* | ifavailable,* | *,yes) ;;
  *) MISSING="$MISSING gnutls"
     WITH_IFAVAILABLE="$WITH_IFAVAILABLE --with-gnutls=ifavailable";;
esac
case $with_json,$HAVE_JSON in
  no,* | ifavailable,* | *,yes) ;;
  *) MISSING="$MISSING json"
     WITH_IFAVAILABLE="$WITH_IFAVAILABLE --with-json=ifavailable";;
esac

But if I understand autoconf (and I do not), that shouldn't really
"spread" to the OPTION_DEFAULT_ stuff, should it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Fri, 02 Oct 2020 18:06:41 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: syohex <at> gmail.com,  43754 <at> debbugs.gnu.org
> Date: Fri, 02 Oct 2020 16:28:38 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Any reason why we use OPTION_DEFAULT_IFAVAILABLE for json, and not
> > OPTION_DEFAULT_ON?  How is it different from libpng or liblcms2 or
> > libgnutls?
> 
> I wonder whether it's because of this:
> 
> case $with_gnutls,$HAVE_GNUTLS in
>   no,* | ifavailable,* | *,yes) ;;
>   *) MISSING="$MISSING gnutls"
>      WITH_IFAVAILABLE="$WITH_IFAVAILABLE --with-gnutls=ifavailable";;
> esac
> case $with_json,$HAVE_JSON in
>   no,* | ifavailable,* | *,yes) ;;
>   *) MISSING="$MISSING json"
>      WITH_IFAVAILABLE="$WITH_IFAVAILABLE --with-json=ifavailable";;
> esac

The $MISSING part is for telling the users some libraries they might
want were not available.  I'm saying that libjansson should be treated
the same as, say, libgnutls.

> But if I understand autoconf (and I do not), that shouldn't really
> "spread" to the OPTION_DEFAULT_ stuff, should it?

"Spread" in the sense that it should affect whether we use DEFAULT_ON
or DEFAULT_IFAVAILABLE?  No, I don't think so.

Message #27 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Sat, 03 Oct 2020 19:49:33 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> The $MISSING part is for telling the users some libraries they might
> want were not available.  I'm saying that libjansson should be treated
> the same as, say, libgnutls.
>
>> But if I understand autoconf (and I do not), that shouldn't really
>> "spread" to the OPTION_DEFAULT_ stuff, should it?
>
> "Spread" in the sense that it should affect whether we use DEFAULT_ON
> or DEFAULT_IFAVAILABLE?  No, I don't think so.

Yes, I'm just wondering if whoever added the OPTION_DEFAULT_AVAILABLE
did it by mistake by looking at this stuff, or whether there was a
reason for it.

Oh, hey, whaddayaknow, it was a patch I applied a couple months ago:

commit 43091e6c5069797ba17d2c7429e0122d3a5337d9
Author:     Noam Postavsky <npostavs <at> gmail.com>
AuthorDate: Fri Aug 14 19:31:16 2020 +0200
Commit:     Lars Ingebrigtsen <larsi <at> gnus.org>
CommitDate: Fri Aug 14 19:31:16 2020 +0200

    Make configure say so if we have "--with-json" but no jansson support
    
    * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro.  Use it to
    define the --with-json option.  Add with_json and HAVE_JSON to the
    'MISSING' checks (bug#39953).

bug#39953 has the rationale behind the change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Sat, 03 Oct 2020 20:59:19 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: syohex <at> gmail.com,  43754 <at> debbugs.gnu.org
> Date: Sat, 03 Oct 2020 19:49:33 +0200
> 
> Oh, hey, whaddayaknow, it was a patch I applied a couple months ago:
> 
> commit 43091e6c5069797ba17d2c7429e0122d3a5337d9
> Author:     Noam Postavsky <npostavs <at> gmail.com>
> AuthorDate: Fri Aug 14 19:31:16 2020 +0200
> Commit:     Lars Ingebrigtsen <larsi <at> gnus.org>
> CommitDate: Fri Aug 14 19:31:16 2020 +0200
> 
>     Make configure say so if we have "--with-json" but no jansson support
>     
>     * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro.  Use it to
>     define the --with-json option.  Add with_json and HAVE_JSON to the
>     'MISSING' checks (bug#39953).
> 
> bug#39953 has the rationale behind the change.

What I said there notwithstanding, it looks like --with-json is the
odd one out nowadays, as we handle all the other optional libraries
differently.  So it seems to me that we should switch to DEFAULT_ON
for this library.

Obviously, it is not a catastrophe to leave it as it is now...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.