GNU bug report logs - #43754
[PATCH] configure help message of --with-json

Previous Next

Package: emacs;

Reported by: Shohei Yoshida <syohex <at> gmail.com>

Date: Fri, 2 Oct 2020 00:49:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #27 received at 43754 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43754 <at> debbugs.gnu.org, syohex <at> gmail.com
Subject: Re: bug#43754: [PATCH] configure help message of --with-json
Date: Sat, 03 Oct 2020 19:49:33 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> The $MISSING part is for telling the users some libraries they might
> want were not available.  I'm saying that libjansson should be treated
> the same as, say, libgnutls.
>
>> But if I understand autoconf (and I do not), that shouldn't really
>> "spread" to the OPTION_DEFAULT_ stuff, should it?
>
> "Spread" in the sense that it should affect whether we use DEFAULT_ON
> or DEFAULT_IFAVAILABLE?  No, I don't think so.

Yes, I'm just wondering if whoever added the OPTION_DEFAULT_AVAILABLE
did it by mistake by looking at this stuff, or whether there was a
reason for it.

Oh, hey, whaddayaknow, it was a patch I applied a couple months ago:

commit 43091e6c5069797ba17d2c7429e0122d3a5337d9
Author:     Noam Postavsky <npostavs <at> gmail.com>
AuthorDate: Fri Aug 14 19:31:16 2020 +0200
Commit:     Lars Ingebrigtsen <larsi <at> gnus.org>
CommitDate: Fri Aug 14 19:31:16 2020 +0200

    Make configure say so if we have "--with-json" but no jansson support
    
    * configure.ac (OPTION_DEFAULT_IFAVAILABLE): New macro.  Use it to
    define the --with-json option.  Add with_json and HAVE_JSON to the
    'MISSING' checks (bug#39953).

bug#39953 has the rationale behind the change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 266 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.