GNU bug report logs - #43635
[PATCH] gnu: Add emacs-sqlite.

Previous Next

Full log

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 43635-done <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#43635] hope, this is right
Date: Thu, 01 Oct 2020 15:42:17 +0200

Hello,

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add emacs-sqlite.el

Thank you. I applied your patch with the changes detailed below.

> +  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit
> +	(revision "0"))

I moved the comment on the line above since comments starting with two
semicolons are expected to stand by their own line.

> +    (package
> +      (name "emacs-sqlite.el")

I changed the name to "emacs-sqlite". Ditto for the name of the variable.

> +      (synopsis "SQLite Interface for Emas Lisp")

I fixed the type and changed case for "Interface".

> +      (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
> +information using the SQLite program through Elisp programming.  It
> is  not intended as a user interface.")

I fixed spacing and renamed the package.

I also moved the package elsewhere, since adding a package at the end of
the file is more likely to cause merge conflicts.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.