GNU bug report logs - #43635
[PATCH] gnu: Add emacs-sqlite.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43635 in the body.
You can then email your comments to 43635 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-sqlite.
Date: Sat, 26 Sep 2020 22:36:58 +0200 (CEST)

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-emacs-sqlite.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 43635 <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#43635] [PATCH] gnu: Add emacs-sqlite.
Date: Sun, 27 Sep 2020 14:31:57 +0200

Hello,

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add emacs-sqlite.
>
> * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable.

Thank you!

Some comments follow.

> +(define-public emacs-sqlite.el

The same should be emacs-sqlite.

> +  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797")
> +	(revision "1"))

You need to provide a comment explaining why you're choosing a specific
commit instead of a tagged release (in this case, that's because there
is no tagged commit).

Also, mind the indentation. (revision ...) should be vertically aligned
with (commit ...)

> +    (package
> +      (name "emacs-sqlite.el")

See above.

> +      (build-system emacs-build-system)
> +      (version (git-version "0.0.0" revision commit))

The base version is "1.0" per keyword in the main Elisp file, not
"0.0.0".

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +	       (url "https://gitlab.com/cnngimenez/sqlite.el.git")

You can drop the ".git" suffix in the URL.

> +	       (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd"))))

(base32 ...) should be moved on the line below.

> +      (home-page "https://gitlab.com/cnngimenez/sqlite.el.git")

Likewise, please drop the ".git" suffix.

> +      (synopsis "SQLite Interface for EmasLisp")

There's a typo in EmacsLisp, which I suggest to write "Emacs Lisp".

> +      (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers:
> +    @cnngimenez
> +    @KIDD (Raimon Grau)")

This description is not useful. I suggest to use the one from EmacsWiki,
quoted here:

  @code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
  information using the SQLite program through Elisp programming.  It is
  not intended as a user interface.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 43635 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: 43635 <at> debbugs.gnu.org
Subject: hope, this is right
Date: Sun, 27 Sep 2020 15:18:22 +0200 (CEST)

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-emacs-sqlite.el.patch (text/x-patch, attachment)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 43635-done <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#43635] hope, this is right
Date: Thu, 01 Oct 2020 15:42:17 +0200

Hello,

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add emacs-sqlite.el

Thank you. I applied your patch with the changes detailed below.

> +  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit
> +	(revision "0"))

I moved the comment on the line above since comments starting with two
semicolons are expected to stand by their own line.

> +    (package
> +      (name "emacs-sqlite.el")

I changed the name to "emacs-sqlite". Ditto for the name of the variable.

> +      (synopsis "SQLite Interface for Emas Lisp")

I fixed the type and changed case for "Interface".

> +      (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
> +information using the SQLite program through Elisp programming.  It
> is  not intended as a user interface.")

I fixed spacing and renamed the package.

I also moved the package elsewhere, since adding a package at the end of
the file is more likely to cause merge conflicts.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.