GNU bug report logs - #43619
[PATCH 1/2] gnu: Add liburing.

Previous Next

Full log

Message #8 received at 43619 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 43619 <at> debbugs.gnu.org
Subject: Re: [bug#43619] [PATCH 1/2] gnu: Add liburing.
Date: Tue, 29 Sep 2020 22:38:33 +0200

Hi Greg,

Greg Hogan <code <at> greghogan.com> skribis:

>>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 22 Sep 2020 15:21:43 +0000
> Subject: [PATCH 1/2] gnu: Add liburing.
>
> * gnu/packages/liburing.scm (liburing): New variable.

[...]

> +(define-module (gnu packages liburing)

I would tend to put it in another module, probably (gnu packages linux)
in this case because it’s Linux-specific.

> +    (arguments
> +     `(#:tests? #f

Please add a comment explaining why the test suite is skipped.

> +    (home-page "https://github.com/axboe/liburing")
> +    (synopsis "Simplified interface for io_uring")

Maybe “Interface to the Linux kernel @code{io_uring} interface”?

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.