GNU bug report logs - #43619
[PATCH 1/2] gnu: Add liburing.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43619 in the body.
You can then email your comments to 43619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add liburing.
Date: Fri, 25 Sep 2020 14:11:56 -0400

[Message part 1 (text/plain, inline)]

From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
From: Greg Hogan <code <at> greghogan.com>
Date: Tue, 22 Sep 2020 15:21:43 +0000
Subject: [PATCH 1/2] gnu: Add liburing.

* gnu/packages/liburing.scm (liburing): New variable.
---
 gnu/local.mk              |  1 +
 gnu/packages/liburing.scm | 58 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 gnu/packages/liburing.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index f3b5b17e84..99e9b5a6ab 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -324,6 +324,7 @@ GNU_SYSTEM_MODULES =                                \
   %D%/packages/libffcall.scm                   \
   %D%/packages/libffi.scm                      \
   %D%/packages/libftdi.scm                     \
+  %D%/packages/liburing.scm                    \
   %D%/packages/license.scm                     \
   %D%/packages/calendar.scm                    \
   %D%/packages/libidn.scm                      \
diff --git a/gnu/packages/liburing.scm b/gnu/packages/liburing.scm
new file mode 100644
index 0000000000..261df445b0
--- /dev/null
+++ b/gnu/packages/liburing.scm
@@ -0,0 +1,58 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Greg Hogan <code <at> greghogan.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages liburing)
+  #:use-module (gnu packages)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu))
+
+(define-public liburing
+  (package
+    (name "liburing")
+    (version "0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.dk/liburing")
+                    (commit (string-append "liburing-" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15z44l7y4c6s6dlf7v8lq4znlsjbja2r4ifbni0l8cdcnq0w3zh3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           ;; configure fails if it is followed by SHELL, CONFIG_SHELL,
+           ;; --enable-fast-install, and --build
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (setenv "SHELL" (which "sh"))
+               (setenv "CONFIG_SHELL" (which "sh"))
+               (invoke "./configure" (string-append "--prefix=" out))))))))
+    (home-page "https://github.com/axboe/liburing")
+    (synopsis "Simplified interface for io_uring")
+    (description "This is the io_uring library, liburing. liburing provides
+helpers to setup and teardown io_uring instances, and also a simplified
+interface for applications that don't need (or want) to deal with the full
+kernel side implementation.")
+    (license expat)))
-- 
2.28.0

[Message part 2 (text/html, inline)]

Message #8 received at 43619 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 43619 <at> debbugs.gnu.org
Subject: Re: [bug#43619] [PATCH 1/2] gnu: Add liburing.
Date: Tue, 29 Sep 2020 22:38:33 +0200

Hi Greg,

Greg Hogan <code <at> greghogan.com> skribis:

>>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 22 Sep 2020 15:21:43 +0000
> Subject: [PATCH 1/2] gnu: Add liburing.
>
> * gnu/packages/liburing.scm (liburing): New variable.

[...]

> +(define-module (gnu packages liburing)

I would tend to put it in another module, probably (gnu packages linux)
in this case because it’s Linux-specific.

> +    (arguments
> +     `(#:tests? #f

Please add a comment explaining why the test suite is skipped.

> +    (home-page "https://github.com/axboe/liburing")
> +    (synopsis "Simplified interface for io_uring")

Maybe “Interface to the Linux kernel @code{io_uring} interface”?

Could you send an updated patch?

Thanks,
Ludo’.

Message #11 received at 43619 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43619 <at> debbugs.gnu.org
Subject: Re: [bug#43619] [PATCH 1/2] gnu: Add liburing.
Date: Sat, 10 Oct 2020 12:15:29 -0400

[Message part 1 (text/plain, inline)]

Moved to gnu/packages/linux, updated the synopsis, and added a remark for
the disabled tests.

From b59f56f3910807dca82075293224f42e8c703039 Mon Sep 17 00:00:00 2001
From: Greg Hogan <code <at> greghogan.com>
Date: Wed, 30 Sep 2020 19:00:53 +0000
Subject: [PATCH] gnu: Add liburing.

* gnu/packages/linux.scm (liburing): New variable.
---
 gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 5486a1031c..02f98ba3ce 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -7585,3 +7585,38 @@ iptables rule and benefit from the speed of IP sets.
 @end itemize\n
 then IP sets may be the proper tool for you.")
     (license license:gpl2+)))
+
+(define-public liburing
+  (package
+    (name "liburing")
+    (version "0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.dk/liburing")
+                    (commit (string-append "liburing-" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15z44l7y4c6s6dlf7v8lq4znlsjbja2r4ifbni0l8cdcnq0w3zh3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(;; Tests are dependent on kernel version and features
+       #:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           ;; configure fails if it is followed by SHELL, CONFIG_SHELL,
+           ;; --enable-fast-install, and --build
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (setenv "SHELL" (which "sh"))
+               (setenv "CONFIG_SHELL" (which "sh"))
+               (invoke "./configure" (string-append "--prefix=" out))))))))
+    (home-page "https://github.com/axboe/liburing")
+    (synopsis "Interface to the Linux kernel @code{io_uring} interface")
+    (description "This is the io_uring library, liburing. liburing provides
+helpers to setup and teardown io_uring instances, and also a simplified
+interface for applications that don't need (or want) to deal with the full
+kernel side implementation.")
+    (license expat)))
-- 
2.28.0

On Tue, Sep 29, 2020 at 4:38 PM Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Greg,
>
> Greg Hogan <code <at> greghogan.com> skribis:
>
> >>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
> > From: Greg Hogan <code <at> greghogan.com>
> > Date: Tue, 22 Sep 2020 15:21:43 +0000
> > Subject: [PATCH 1/2] gnu: Add liburing.
> >
> > * gnu/packages/liburing.scm (liburing): New variable.
>
> [...]
>
> > +(define-module (gnu packages liburing)
>
> I would tend to put it in another module, probably (gnu packages linux)
> in this case because it’s Linux-specific.
>
> > +    (arguments
> > +     `(#:tests? #f
>
> Please add a comment explaining why the test suite is skipped.
>
> > +    (home-page "https://github.com/axboe/liburing")
> > +    (synopsis "Simplified interface for io_uring")
>
> Maybe “Interface to the Linux kernel @code{io_uring} interface”?
>
> Could you send an updated patch?
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #16 received at 43619-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 43619-done <at> debbugs.gnu.org
Subject: Re: [bug#43619] [PATCH 1/2] gnu: Add liburing.
Date: Sat, 10 Oct 2020 22:50:17 +0200

[Message part 1 (text/plain, inline)]

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> Moved to gnu/packages/linux, updated the synopsis, and added a remark for
> the disabled tests.

Great.  Applied with the minor tweaks below.

Thank you!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 8061457e2e..39960c102b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -49,6 +49,7 @@
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2020 Anders Thuné <asse.97 <at> gmail.com>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Greg Hogan <code <at> greghogan.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7619,4 +7620,4 @@ then IP sets may be the proper tool for you.")
 helpers to setup and teardown io_uring instances, and also a simplified
 interface for applications that don't need (or want) to deal with the full
 kernel side implementation.")
-    (license expat)))
+    (license license:expat)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.