GNU bug report logs - #43551
[PATCH] Add package emacs-quickrun

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 43551 <at> debbugs.gnu.org
Subject: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Tue, 22 Sep 2020 11:07:06 +0200

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-quickrun.

Thank you.

> +(define-public emacs-quickrun
> +  (let ((commit "0133cac651918071a824e85b55e10d44f32a1979")
> +        (revision "0"))

I don't think there is any reason to use a commit directly, since this
one matches a release.

> +    (package
> +      (name "emacs-quickrun")
> +      (version (git-version "2.3.1" revision commit))

    (version "2.3.1")

is enough per above.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/emacsorphanage/quickrun")
> +               (commit commit)))

    (commit version)

> +         (sha256
> +          (base32
> +           "0a1n2v09h0n7d9p2izflqqang4ny0b46dlqvmxvkkik4bb6f4wcz"))

Please move the hash string on the same line as base32.

> +         (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (home-page
> +       "https://github.com/emacsorphanage/quickrun")

Please move the URL on the same line as home-page

> +      (synopsis "Run commands quickly")
> +      (description
> +       "This package evaluates the content of a buffer, or region and displays
> +the result.  It is similar to executable-interpret, but provides more
> +convenient commands.  Quickrun execute not only script languages(Perl, Ruby,

Quickrun executes ... languages (Perl

> +Python etc), but also compiling languages(C, C++, Go, Java etc) and
> markup

Mind the missing space here, too.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.