GNU bug report logs - #43551
[PATCH] Add package emacs-quickrun

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43551 in the body.
You can then email your comments to 43551 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add package emacs-quickrun
Date: Mon, 21 Sep 2020 16:32:05 +0200

[0001-gnu-Add-emacs-quickrun.patch (text/x-patch, attachment)]

From ec5a8a6d3ded11f48d12e66018790b2d03bbd624 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund <at> posteo.net>
Date: Mon, 21 Sep 2020 12:44:55 +0200
Subject: [PATCH] gnu: Add emacs-quickrun.

* gnu/packages/emacs-xyz.scm (emacs-quickrun): New variable.
---
 gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4634836b89..8aa4304312 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -78,6 +78,7 @@
 ;;; Copyright © 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
+;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24647,3 +24648,31 @@ publically-accessible HTTP server.")
 label references and citations in LaTeX.  It is based on RefTeX, which is
 included with Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-quickrun
+  (let ((commit "0133cac651918071a824e85b55e10d44f32a1979")
+        (revision "0"))
+    (package
+      (name "emacs-quickrun")
+      (version (git-version "2.3.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/emacsorphanage/quickrun")
+               (commit commit)))
+         (sha256
+          (base32
+           "0a1n2v09h0n7d9p2izflqqang4ny0b46dlqvmxvkkik4bb6f4wcz"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page
+       "https://github.com/emacsorphanage/quickrun")
+      (synopsis "Run commands quickly")
+      (description
+       "This package evaluates the content of a buffer, or region and displays
+the result.  It is similar to executable-interpret, but provides more
+convenient commands.  Quickrun execute not only script languages(Perl, Ruby,
+Python etc), but also compiling languages(C, C++, Go, Java etc) and markup
+languages.")
+      (license license:gpl3+))))
-- 
2.28.0

Message #8 received at 43551 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 43551 <at> debbugs.gnu.org
Subject: Re: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Tue, 22 Sep 2020 11:07:06 +0200

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-quickrun.

Thank you.

> +(define-public emacs-quickrun
> +  (let ((commit "0133cac651918071a824e85b55e10d44f32a1979")
> +        (revision "0"))

I don't think there is any reason to use a commit directly, since this
one matches a release.

> +    (package
> +      (name "emacs-quickrun")
> +      (version (git-version "2.3.1" revision commit))

    (version "2.3.1")

is enough per above.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/emacsorphanage/quickrun")
> +               (commit commit)))

    (commit version)

> +         (sha256
> +          (base32
> +           "0a1n2v09h0n7d9p2izflqqang4ny0b46dlqvmxvkkik4bb6f4wcz"))

Please move the hash string on the same line as base32.

> +         (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (home-page
> +       "https://github.com/emacsorphanage/quickrun")

Please move the URL on the same line as home-page

> +      (synopsis "Run commands quickly")
> +      (description
> +       "This package evaluates the content of a buffer, or region and displays
> +the result.  It is similar to executable-interpret, but provides more
> +convenient commands.  Quickrun execute not only script languages(Perl, Ruby,

Quickrun executes ... languages (Perl

> +Python etc), but also compiling languages(C, C++, Go, Java etc) and
> markup

Mind the missing space here, too.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 43551 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 43551 <at> debbugs.gnu.org
Subject: Re: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Tue, 22 Sep 2020 11:33:47 +0200

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Could you send an updated patch?

> Regards,
> -- 
> Nicolas Goaziou

Hi Nicolas,

Thanks for your review. I will address your comments and create an
updated patch. It's my first time contributing to guix, so I hope I am
sending this message correctly :)

// Niklas

Message #14 received at 43551 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: 43551 <at> debbugs.gnu.org
Subject: Re: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Tue, 22 Sep 2020 14:37:11 +0200

[0001-gnu-Add-emacs-quickrun.patch (text/x-patch, attachment)]

From 4d1c89943b0157701f66f304da24ad461db38007 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund <at> posteo.net>
Date: Mon, 21 Sep 2020 12:44:55 +0200
Subject: [PATCH] gnu: Add emacs-quickrun.

* gnu/packages/emacs-xyz.scm (emacs-quickrun): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4634836b89..2c884ef3a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -78,6 +78,7 @@
 ;;; Copyright © 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
+;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24647,3 +24648,27 @@ publically-accessible HTTP server.")
 label references and citations in LaTeX.  It is based on RefTeX, which is
 included with Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-quickrun
+  (package
+    (name "emacs-quickrun")
+    (version "2.3.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/emacsorphanage/quickrun")
+             (commit version)))
+       (sha256
+        (base32 "0a1n2v09h0n7d9p2izflqqang4ny0b46dlqvmxvkkik4bb6f4wcz"))
+       (file-name (git-file-name name version))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/emacsorphanage/quickrun")
+    (synopsis "Run commands quickly")
+    (description
+     "This package evaluates the content of a buffer, or region and displays
+the result.  It is similar to executable-interpret, but provides more
+convenient commands.  Quickrun execute not only script languages (Perl, Ruby,
+Python etc), but also compiling languages (C, C++, Go, Java etc) and markup
+languages.")
+    (license license:gpl3+)))
-- 
2.28.0

Message #19 received at 43551-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 43551-done <at> debbugs.gnu.org
Subject: Re: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Wed, 23 Sep 2020 21:39:54 +0200

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-quickrun.
>
> * gnu/packages/emacs-xyz.scm (emacs-quickrun): New variable.

I tweaked the synopsis and the description and applied your patch. Thank
you!

Note that adding a package definition at the end of the file is
generally not a good idea, because it is more likely to introduce
conflicts.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.