GNU bug report logs - #43496
28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here

Previous Next

Package: emacs;

Reported by: Alex Bochannek <alex <at> bochannek.com>

Date: Fri, 18 Sep 2020 21:36:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Bochannek <alex <at> bochannek.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here
Date: Fri, 18 Sep 2020 14:35:31 -0700

[Message part 1 (text/plain, inline)]
The gnus-summary-catchup-from-here function also marks the current
article, which it fails to do if that article is the last one in the
summary buffer.

[gnus-sum.el.diff (text/x-patch, inline)]
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 2f0ea0c58f..8e27a94e5b 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here
     (gnus-save-hidden-threads
       (let ((beg (point)))
 	;; We check that there are unread articles.
-	(when (or all (gnus-summary-find-next))
+	(when (or all (gnus-summary-last-article-p) (gnus-summary-find-next))
 	  (gnus-summary-catchup all t beg nil t)))))
   (gnus-summary-position-point))

[Message part 3 (text/plain, inline)]
-- 
Alex.
This bug report was last modified 4 years and 306 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.