GNU bug report logs - #43496
28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here

Previous Next

Package: emacs;

Reported by: Alex Bochannek <alex <at> bochannek.com>

Date: Fri, 18 Sep 2020 21:36:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43496 in the body.
You can then email your comments to 43496 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43496; Package emacs. (Fri, 18 Sep 2020 21:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Alex Bochannek <alex <at> bochannek.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 18 Sep 2020 21:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Bochannek <alex <at> bochannek.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here
Date: Fri, 18 Sep 2020 14:35:31 -0700

[Message part 1 (text/plain, inline)]
The gnus-summary-catchup-from-here function also marks the current
article, which it fails to do if that article is the last one in the
summary buffer.

[gnus-sum.el.diff (text/x-patch, inline)]
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 2f0ea0c58f..8e27a94e5b 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here
     (gnus-save-hidden-threads
       (let ((beg (point)))
 	;; We check that there are unread articles.
-	(when (or all (gnus-summary-find-next))
+	(when (or all (gnus-summary-last-article-p) (gnus-summary-find-next))
 	  (gnus-summary-catchup all t beg nil t)))))
   (gnus-summary-position-point))

[Message part 3 (text/plain, inline)]
-- 
Alex.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43496; Package emacs. (Sat, 19 Sep 2020 14:51:02 GMT) Full text and rfc822 format available.

Message #8 received at 43496 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Bochannek <alex <at> bochannek.com>
Cc: 43496 <at> debbugs.gnu.org
Subject: Re: bug#43496: 28.0.50; [PATCH] Fix edge case in
 gnus-summary-catchup-from-here
Date: Sat, 19 Sep 2020 16:49:51 +0200

Alex Bochannek <alex <at> bochannek.com> writes:

> The gnus-summary-catchup-from-here function also marks the current
> article, which it fails to do if that article is the last one in the
> summary buffer.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 14:51:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 43496 <at> debbugs.gnu.org and Alex Bochannek <alex <at> bochannek.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 14:51:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Oct 2020 11:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 305 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.