GNU bug report logs - #43467
28.0.50; [PATCH] defcustom warning-show-suppression-buttons

Previous Next

Full log

View this message in rfc822 format

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43467 <at> debbugs.gnu.org
Subject: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction
Date: Thu, 17 Sep 2020 13:09:13 -0400

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Thanks for the feedback, Lars.

> Warnings are something you should rarely get, so I'm not quite 
> sure I
> see the use case for this?  In any case, some minor comments...

The same argument could be made against the buttons/suppression 
themselves:

"Warnings are something you should rarely get, so I'm not quite 
sure I see the use case for suppressing them."

I don't see either as a particularly strong argument.
For me, the buttons are useless because I have `custom-file` set 
to `null-device'.
They just add visual clutter to the buffer in that case.
The customization seems pretty low-cost in terms of 
complexity/maintenance IMO and provides the flexibility
to accommodate my (and possibly other we haven't thought of) use 
cases.

> And perhaps this would be clearer as a (when (and .. instead.

Addressed by changing the customization to 
`warning-hide-suppression-buttons' and inverting the semantics in 
the attached patch.

[0001-warning-hide-suppression-buttons.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.