GNU bug report logs - #43467
28.0.50; [PATCH] defcustom warning-show-suppression-buttons

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43467 in the body.
You can then email your comments to 43467 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons
Date: Thu, 17 Sep 2020 11:52:04 -0400

[Message part 1 (text/plain, inline)]

User-agent: mu4e 1.5.5; emacs 28.0.50
User-agent: mu4e 1.5.5; emacs 28.0.50
BCC: No Wayman <iarchivedmywholelife <at> gmail.com>

The new warning suppression button behavior introduced in 
66d01012ba61a364fe92cdc1728bfa135a90626a
is a great idea, but I don't have much use for it and would prefer 
to not have the buttons clutter
the *Warnings* buffer.

The attached patch introduces a defcustom to control the display 
of the buttons.

Thanks,

Nicholas Vollmer

[0001-Allow-customization-of-warning-suppression-button-di.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Date: Thu, 17 Sep 2020 11:52:04 -0400

Message #8 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: 43467 <at> debbugs.gnu.org
Subject: [PATCH] defcustom warning-show-suppression-buttons correction
Date: Thu, 17 Sep 2020 12:04:20 -0400

[Message part 1 (text/plain, inline)]

Sorry, just woke up. The attached patch corrects the logic of the 
first one.

[0001-warning-show-suppression-buttons-defcustom.patch (text/x-patch, attachment)]

Message #11 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 18:13:57 +0200

>>>>> On Thu, 17 Sep 2020 12:04:20 -0400, No Wayman <iarchivedmywholelife <at> gmail.com> said:

    No> Sorry, just woke up. The attached patch corrects the logic of the
    No> first one.

    No> From 0f5caefcfe496ebccfedf24cfc75b249e1e7bf76 Mon Sep 17 00:00:00 2001
    No> From: Nicholas Vollmer <iarchivedmywholelife <at> gmail.com>
    No> Date: Thu, 17 Sep 2020 11:40:41 -0400
    No> Subject: [PATCH] Allow customization of warning suppression button display

    No> * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
    No> new defcustom to disable/enable display of warning suppression buttons
    No> in *Warnings* buffer.
    No> ---
    No>  lisp/emacs-lisp/warnings.el | 7 ++++++-
    No>  1 file changed, 6 insertions(+), 1 deletion(-)

    No> diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
    No> index e10c149d89..8ed4e425f3 100644
    No> --- a/lisp/emacs-lisp/warnings.el
    No> +++ b/lisp/emacs-lisp/warnings.el
    No> @@ -116,6 +116,11 @@ warning-suppress-types
    No>  See also `warning-suppress-log-types'."
    No>    :type '(repeat (repeat symbol))
    No>    :version "22.1")
    No> +
    No> +(defcustom warning-show-suppression-buttons t
    No> +  "Whether or not to show suppresion buttons in the *Warnings* buffer.
    No> +If t, buttons are shown, else they are not."
    No> +  :type 'boolean)

Your defcustom needs a :version "28.1"

Robert

Message #14 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 18:16:13 +0200

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
> new defcustom to disable/enable display of warning suppression buttons
> in *Warnings* buffer.

Warnings are something you should rarely get, so I'm not quite sure I
see the use case for this?  In any case, some minor comments...

> +(defcustom warning-show-suppression-buttons t
> +  "Whether or not to show suppresion buttons in the *Warnings* buffer.

                            suppression

> +If t, buttons are shown, else they are not."

We usually say "if non-nil", not "t".

> +  :type 'boolean)

And there should be a :version here.

> -              (unless noninteractive
> +              (unless (or noninteractive (not warning-show-suppression-buttons))

And perhaps this would be clearer as a (when (and .. instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 12:24:20 -0400

[Message part 1 (text/plain, inline)]

Robert Pluim <rpluim <at> gmail.com> writes:
> Your defcustom needs a :version "28.1"

Thanks, Robert. Addressed in attached patch.

[0001-warning-show-suppression-buttons-take-three.patch (text/x-patch, attachment)]

Message #20 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 13:09:13 -0400

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Thanks for the feedback, Lars.

> Warnings are something you should rarely get, so I'm not quite 
> sure I
> see the use case for this?  In any case, some minor comments...

The same argument could be made against the buttons/suppression 
themselves:

"Warnings are something you should rarely get, so I'm not quite 
sure I see the use case for suppressing them."

I don't see either as a particularly strong argument.
For me, the buttons are useless because I have `custom-file` set 
to `null-device'.
They just add visual clutter to the buffer in that case.
The customization seems pretty low-cost in terms of 
complexity/maintenance IMO and provides the flexibility
to accommodate my (and possibly other we haven't thought of) use 
cases.

> And perhaps this would be clearer as a (when (and .. instead.

Addressed by changing the customization to 
`warning-hide-suppression-buttons' and inverting the semantics in 
the attached patch.

[0001-warning-hide-suppression-buttons.patch (text/x-patch, attachment)]

Message #23 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 19:27:45 +0200

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

>> Warnings are something you should rarely get, so I'm not quite sure I
>> see the use case for this?  In any case, some minor comments...
>
> The same argument could be made against the buttons/suppression
> themselves:
>
> "Warnings are something you should rarely get, so I'm not quite sure I
> see the use case for suppressing them."

No, the opposite -- since you get the warnings so seldom, it makes sense
to have the very few you see come with ready-made ways of making them go
away, and then you're back to no warnings again.

> I don't see either as a particularly strong argument.
> For me, the buttons are useless because I have `custom-file` set to
> `null-device'.

I think that's a very unusual thing to do, so it doesn't seem much like
a use case.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #26 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 14:08:10 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> I think that's a very unusual thing to do, so it doesn't seem 
> much like
> a use case.

We don't see eye to eye on this, but fair enough.
I've offered the patch and my justification. I have nothing more 
to add.

Message #29 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Fri, 18 Sep 2020 15:14:03 +0200

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> We don't see eye to eye on this, but fair enough.
> I've offered the patch and my justification. I have nothing more to
> add.

OK; then it seems unlikely that we'll make further progress in this bug
report, and I'm closing it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.