GNU bug report logs - #43467
28.0.50; [PATCH] defcustom warning-show-suppression-buttons

Previous Next

Full log

Message #14 received at 43467 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 43467 <at> debbugs.gnu.org
Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons
 correction
Date: Thu, 17 Sep 2020 18:16:13 +0200

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons):
> new defcustom to disable/enable display of warning suppression buttons
> in *Warnings* buffer.

Warnings are something you should rarely get, so I'm not quite sure I
see the use case for this?  In any case, some minor comments...

> +(defcustom warning-show-suppression-buttons t
> +  "Whether or not to show suppresion buttons in the *Warnings* buffer.

                            suppression

> +If t, buttons are shown, else they are not."

We usually say "if non-nil", not "t".

> +  :type 'boolean)

And there should be a :version here.

> -              (unless noninteractive
> +              (unless (or noninteractive (not warning-show-suppression-buttons))

And perhaps this would be clearer as a (when (and .. instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.